Linux kernel -stable discussions
 help / color / mirror / Atom feed
From: "Ricardo Cañuelo Navarro" <rcn@igalia.com>
To: Greg KH <greg@kroah.com>
Cc: stable@vger.kernel.org, bigeasy@linutronix.de, revest@google.com,
	kernel-dev@igalia.com
Subject: Re: [PATCH 6.6 1/2] net: Reference bpf_redirect_info via task_struct on PREEMPT_RT.
Date: Mon, 24 Feb 2025 15:21:40 +0100	[thread overview]
Message-ID: <87frk3zamj.fsf@igalia.com> (raw)
In-Reply-To: <2025022454-dislike-unengaged-37e5@gregkh>

Hi Greg, thanks for having a look at it.

On Mon, Feb 24 2025 at 14:55:36, Greg KH <greg@kroah.com> wrote:
> You did major changes to this and you didn't sign off and explain what
> you did differently from the original commit?  You know we can't take
> that...

Yes, I needed to do some manual adjustments to the original upstream
patch in order to apply it to stable... and I just noticed that I
skipped a couple of lines in one of the chunks. My fault.

Except for that, which I'll fix in v2, I didn't introduce any functional
changes to the patch itself, that's why I didn't sign it or explain the
modifications. Except for the changes in the context (and that poorly
edited chunk) the lines introduced by this patch and the upstream one
are identical.

In any case, I'll make the required fixes for v2 and I'll try again,
this time explicitly mentioning that there was some manual work
involved.

Thanks!
Ricardo

  reply	other threads:[~2025-02-24 14:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-24 12:00 [PATCH 6.6 0/2] Set the bpf_net_context before invoking BPF XDP in the TUN driver Ricardo Cañuelo Navarro
2025-02-24 12:00 ` [PATCH 6.6 1/2] net: Reference bpf_redirect_info via task_struct on PREEMPT_RT Ricardo Cañuelo Navarro
2025-02-24 13:55   ` Greg KH
2025-02-24 14:21     ` Ricardo Cañuelo Navarro [this message]
2025-02-24 14:24     ` Ricardo Cañuelo Navarro
2025-02-25 16:13   ` Sasha Levin
2025-02-24 12:00 ` [PATCH 6.6 2/2] tun: Assign missing bpf_net_context Ricardo Cañuelo Navarro
2025-02-25 16:13   ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frk3zamj.fsf@igalia.com \
    --to=rcn@igalia.com \
    --cc=bigeasy@linutronix.de \
    --cc=greg@kroah.com \
    --cc=kernel-dev@igalia.com \
    --cc=revest@google.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox