From: Takashi Iwai <tiwai@suse.de>
To: Gergo Koteles <soyer@irl.hu>
Cc: Shenghao Ding <shenghao-ding@ti.com>, Kevin Lu <kevin-lu@ti.com>,
Baojun Xu <baojun.xu@ti.com>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] ALSA: hda/tas2781: leave hda_component in usable state
Date: Sun, 10 Dec 2023 10:06:27 +0100 [thread overview]
Message-ID: <87fs0a5svg.wl-tiwai@suse.de> (raw)
In-Reply-To: <8b8ed2bd5f75fbb32e354a3226c2f966fa85b46b.1702156522.git.soyer@irl.hu>
On Sat, 09 Dec 2023 22:18:29 +0100,
Gergo Koteles wrote:
>
> Unloading then loading the module causes a NULL ponter dereference.
>
> The hda_unbind zeroes the hda_component, later the hda_bind tries
> to dereference the codec field.
>
> The hda_component is only initialized once by tas2781_generic_fixup.
>
> Set only previously modified fields to NULL.
>
> BUG: kernel NULL pointer dereference, address: 0000000000000322
> Call Trace:
> <TASK>
> ? __die+0x23/0x70
> ? page_fault_oops+0x171/0x4e0
> ? exc_page_fault+0x7f/0x180
> ? asm_exc_page_fault+0x26/0x30
> ? tas2781_hda_bind+0x59/0x140 [snd_hda_scodec_tas2781_i2c]
> component_bind_all+0xf3/0x240
> try_to_bring_up_aggregate_device+0x1c3/0x270
> __component_add+0xbc/0x1a0
> tas2781_hda_i2c_probe+0x289/0x3a0 [snd_hda_scodec_tas2781_i2c]
> i2c_device_probe+0x136/0x2e0
>
> Fixes: 5be27f1e3ec9 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
> CC: stable@vger.kernel.org
> Signed-off-by: Gergo Koteles <soyer@irl.hu>
Thanks, applied now.
Takashi
prev parent reply other threads:[~2023-12-10 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 21:18 [PATCH v3] ALSA: hda/tas2781: leave hda_component in usable state Gergo Koteles
2023-12-10 9:06 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fs0a5svg.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=baojun.xu@ti.com \
--cc=kevin-lu@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shenghao-ding@ti.com \
--cc=soyer@irl.hu \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox