stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: Eric Blau <eblau@eblau.com>,
	Damian Dominik Martinez Dreyer <damian@mailbox.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	intel-gfx@lists.freedesktop.org, stable@vger.kernel.org,
	Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume
Date: Mon, 20 Mar 2017 17:01:34 +0200	[thread overview]
Message-ID: <87fui8at69.fsf@intel.com> (raw)
In-Reply-To: <CADU241M-W-axz4uHV7eQBFPj4tiNJjKkq33qfSnvjc=CBZxmKA@mail.gmail.com>

On Tue, 14 Mar 2017, Eric Blau <eblau@eblau.com> wrote:
> That's funny. I have a MacBook Pro 12,1 from late 2015. Hibernate
> failed for me in 4.9.6 through 4.9.8 (possibly earlier as well, I do
> no recall) without the patch. The patch you reference fixed my problem
> and apparently many others based on the bug reports:
>
> https://bugs.freedesktop.org/show_bug.cgi?id=96526
>
> I applied the patch myself in 4.9.6 through 4.9.8 and hibernate works
> for me. I have run vanilla 4.9.9 and 4.10.1 and in both hibernate
> works.

So I'm quite surprised

commit f2a0409a08502d64fbe3990354dff5902b08d2fb
Author: Chris Wilson <chris@chris-wilson.co.uk>
Date:   Wed Sep 21 14:51:08 2016 +0100

    drm/i915/execlists: Reset RING registers upon resume
    
    commit bafb2f7d4755bf1571bd5e9a03b97f3fc4fe69ae upstream.

ended up in v4.9.9 considering that the upstream commit is not annotated
for stable, it has no Fixes: tags, and I can't find any backport
requests or even notifications for it in my mails. (Admittedly I'm not
subscribed on stable@, but I'd expect our lists, maintainers or
developers be Cc'd.)

BR,
Jani.


>
> Regards,
> Eric
>
> On Mon, Mar 13, 2017 at 6:23 PM, Damian Dominik Martinez Dreyer
> <damian@mailbox.org> wrote:
>> I am writing regarding this kernel patch: https://git.kernel.org/pub/sc
>> m/linux/kernel/git/stable/stable-queue.git/tree/releases/4.9.9/drm-
>> i915-execlists-reset-ring-registers-upon-resume.patch .
>>
>> I have identified this by bisect to be the cause of a suspend and
>> resume issue. Please see https://github.com/kxv/linux49.9 for the
>> bisect history.
>>
>> After this change, a Laptop (HP Spectre x360) with Intel HD Graphics
>> 520 will wake up from suspend to a blank screen.
>>
>> Please also see this thread on the manjaro linux forum: https://forum.m
>> anjaro.org/t/linux-4-9-9-breaks-hibernation-4-9-8-works/17499 .
>>
>>
>> Best regards
>> Damian Dominik Martinez Dreyer
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Jani Nikula, Intel Open Source Technology Center

       reply	other threads:[~2017-03-20 15:05 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1489443835.5568.7.camel@mailbox.org>
     [not found] ` <CADU241M-W-axz4uHV7eQBFPj4tiNJjKkq33qfSnvjc=CBZxmKA@mail.gmail.com>
2017-03-20 15:01   ` Jani Nikula [this message]
2017-03-20 15:13     ` [Intel-gfx] Potential BUG in drm/i915/execlists: Reset RING registers upon resume Greg Kroah-Hartman
2017-03-20 15:24       ` Eric Blau
2017-04-12 12:55         ` Greg Kroah-Hartman
2017-04-12 13:35           ` Jani Nikula
2017-04-12 13:55             ` Greg Kroah-Hartman
2017-03-20 15:42       ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fui8at69.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=damian@mailbox.org \
    --cc=eblau@eblau.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).