stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* stable: please queue commit 0231bb5 ("perf: Fix event group context move")
@ 2013-08-05  8:18 Li Zefan
  2013-08-05  8:21 ` Ingo Molnar
  2013-08-05 10:57 ` Luis Henriques
  0 siblings, 2 replies; 4+ messages in thread
From: Li Zefan @ 2013-08-05  8:18 UTC (permalink / raw)
  To: Greg Kroah-Hartman; +Cc: Ingo Molnar, Peter Zijlstra, LKML, stable

Plese consider adding commit 0231bb5336758426b44ccd798ccd3c5419c95d58
to stable tree. It fixes a real bug, which was explained here:

	http://thread.gmane.org/gmane.linux.kernel.perf.user/1144

and I've managed to reproduce the bug in 3.4 kernel with the test
program attached in the above email, and I've confirmed the bug fix.

The effect of the bug is, if we open a group of mixed events(sw/hw)
and the "disabled" flag is not set and sw events come first, then
some of the perf events won't be started after the call to perf_event_open().

The bug fix should be applicable to kernels >= 3.0 && <= 3.7.

--
Li Zefan

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: stable: please queue commit 0231bb5 ("perf: Fix event group context move")
  2013-08-05  8:18 stable: please queue commit 0231bb5 ("perf: Fix event group context move") Li Zefan
@ 2013-08-05  8:21 ` Ingo Molnar
  2013-08-31 20:47   ` Ben Hutchings
  2013-08-05 10:57 ` Luis Henriques
  1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2013-08-05  8:21 UTC (permalink / raw)
  To: Li Zefan; +Cc: Greg Kroah-Hartman, Peter Zijlstra, LKML, stable


* Li Zefan <lizefan@huawei.com> wrote:

> Plese consider adding commit 0231bb5336758426b44ccd798ccd3c5419c95d58
> to stable tree. It fixes a real bug, which was explained here:
> 
> 	http://thread.gmane.org/gmane.linux.kernel.perf.user/1144
> 
> and I've managed to reproduce the bug in 3.4 kernel with the test
> program attached in the above email, and I've confirmed the bug fix.
> 
> The effect of the bug is, if we open a group of mixed events(sw/hw)
> and the "disabled" flag is not set and sw events come first, then
> some of the perf events won't be started after the call to perf_event_open().
> 
> The bug fix should be applicable to kernels >= 3.0 && <= 3.7.

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

	Ingo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: stable: please queue commit 0231bb5 ("perf: Fix event group context move")
  2013-08-05  8:18 stable: please queue commit 0231bb5 ("perf: Fix event group context move") Li Zefan
  2013-08-05  8:21 ` Ingo Molnar
@ 2013-08-05 10:57 ` Luis Henriques
  1 sibling, 0 replies; 4+ messages in thread
From: Luis Henriques @ 2013-08-05 10:57 UTC (permalink / raw)
  To: Li Zefan; +Cc: Greg Kroah-Hartman, Ingo Molnar, Peter Zijlstra, LKML, stable

Li Zefan <lizefan@huawei.com> writes:

> Plese consider adding commit 0231bb5336758426b44ccd798ccd3c5419c95d58
> to stable tree. It fixes a real bug, which was explained here:
>
> 	http://thread.gmane.org/gmane.linux.kernel.perf.user/1144
>
> and I've managed to reproduce the bug in 3.4 kernel with the test
> program attached in the above email, and I've confirmed the bug fix.
>
> The effect of the bug is, if we open a group of mixed events(sw/hw)
> and the "disabled" flag is not set and sw events come first, then
> some of the perf events won't be started after the call to perf_event_open().
>
> The bug fix should be applicable to kernels >= 3.0 && <= 3.7.
>
> --
> Li Zefan
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Thanks, I'm queuing it for the 3.5 kernel.

Cheers,
-- 
Luis

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: stable: please queue commit 0231bb5 ("perf: Fix event group context move")
  2013-08-05  8:21 ` Ingo Molnar
@ 2013-08-31 20:47   ` Ben Hutchings
  0 siblings, 0 replies; 4+ messages in thread
From: Ben Hutchings @ 2013-08-31 20:47 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Li Zefan, Greg Kroah-Hartman, Peter Zijlstra, LKML, stable

[-- Attachment #1: Type: text/plain, Size: 960 bytes --]

On Mon, 2013-08-05 at 10:21 +0200, Ingo Molnar wrote:
> * Li Zefan <lizefan@huawei.com> wrote:
> 
> > Plese consider adding commit 0231bb5336758426b44ccd798ccd3c5419c95d58
> > to stable tree. It fixes a real bug, which was explained here:
> > 
> > 	http://thread.gmane.org/gmane.linux.kernel.perf.user/1144
> > 
> > and I've managed to reproduce the bug in 3.4 kernel with the test
> > program attached in the above email, and I've confirmed the bug fix.
> > 
> > The effect of the bug is, if we open a group of mixed events(sw/hw)
> > and the "disabled" flag is not set and sw events come first, then
> > some of the perf events won't be started after the call to perf_event_open().
> > 
> > The bug fix should be applicable to kernels >= 3.0 && <= 3.7.
> 
> Acked-by: Ingo Molnar <mingo@kernel.org>

Queued up for 3.2, thanks.

Ben.

-- 
Ben Hutchings
If God had intended Man to program,
we'd have been born with serial I/O ports.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-08-31 20:47 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-08-05  8:18 stable: please queue commit 0231bb5 ("perf: Fix event group context move") Li Zefan
2013-08-05  8:21 ` Ingo Molnar
2013-08-31 20:47   ` Ben Hutchings
2013-08-05 10:57 ` Luis Henriques

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).