From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E51A9C433FE for ; Mon, 2 May 2022 10:20:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229549AbiEBKYO (ORCPT ); Mon, 2 May 2022 06:24:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1384506AbiEBKXs (ORCPT ); Mon, 2 May 2022 06:23:48 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A02EBE3D; Mon, 2 May 2022 03:20:19 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5D83DB8136B; Mon, 2 May 2022 10:20:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 05879C385A4; Mon, 2 May 2022 10:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651486817; bh=H/4R1EpBq3eerMw2bv6Q6fjwZU5GW14BHJfL5BIi01c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ZkBM2DVEvOdESoOmys2DpmqzePhzFi2hk0IO6/HkOtTTHgGE+kdBjSTEvI3FQNHng 09NK8z2MBRIWYdOZDaADDLfPvdE41T8KDF7Q3wkRIETWvYcf08FLfHEQHqHPN+Ozs8 ++Zwp0blzkOJHpvMhPsb+rzgZlxFtZZAP4HHor9QuXECEFOSVO4cHRqJuHs1b8TIih TkRh9st5lhW2i+huOxLs9SIHFa43KfASQDF9w3Gm4mBFPgUWcM9ZMPIgUH0BeBUXXN TWmeRrOR8CBk1oOCclBPzExK23KpW0UsE1QIKkeHTrT9sfOhoHXoZgJAfLGtcFi7PZ TlanNJnU6eEaQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nlTA6-008OSK-Dt; Mon, 02 May 2022 11:20:14 +0100 Date: Mon, 02 May 2022 11:20:13 +0100 Message-ID: <87h768i6ci.wl-maz@kernel.org> From: Marc Zyngier To: Hector Martin Cc: Lorenzo Pieralisi , Rob Herring , Krzysztof =?UTF-8?B?V2lsY3p5xYRza2k=?= , Bjorn Helgaas , Alyssa Rosenzweig , Sven Peter , linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/3] PCI: apple: GPIO handling nitfixes In-Reply-To: <20220502093832.32778-2-marcan@marcan.st> References: <20220502093832.32778-1-marcan@marcan.st> <20220502093832.32778-2-marcan@marcan.st> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/27.1 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: marcan@marcan.st, lorenzo.pieralisi@arm.com, robh@kernel.org, kw@linux.com, bhelgaas@google.com, alyssa@rosenzweig.io, sven@svenpeter.dev, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 02 May 2022 10:38:30 +0100, Hector Martin wrote: > > - Use devm managed GPIO getter > - GPIO ops can sleep in this context > > Fixes: 1e33888fbe44 ("PCI: apple: Add initial hardware bring-up") > Cc: stable@vger.kernel.org Why the Cc: stable? I'd guess that at a push, the devm_*() usage help with potential memory leaks when the driver fails to probe, but it would be good to call that out in the commit message. > Signed-off-by: Hector Martin > --- > drivers/pci/controller/pcie-apple.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/pci/controller/pcie-apple.c b/drivers/pci/controller/pcie-apple.c > index a2c3c207a04b..e0c06c0ee731 100644 > --- a/drivers/pci/controller/pcie-apple.c > +++ b/drivers/pci/controller/pcie-apple.c > @@ -516,8 +516,8 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > u32 stat, idx; > int ret, i; > > - reset = gpiod_get_from_of_node(np, "reset-gpios", 0, > - GPIOD_OUT_LOW, "PERST#"); > + reset = devm_gpiod_get_from_of_node(pcie->dev, np, "reset-gpios", 0, > + GPIOD_OUT_LOW, "PERST#"); > if (IS_ERR(reset)) > return PTR_ERR(reset); > > @@ -541,7 +541,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > rmw_set(PORT_APPCLK_EN, port->base + PORT_APPCLK); > > /* Assert PERST# before setting up the clock */ > - gpiod_set_value(reset, 1); > + gpiod_set_value_cansleep(reset, 1); > > ret = apple_pcie_setup_refclk(pcie, port); > if (ret < 0) > @@ -552,7 +552,7 @@ static int apple_pcie_setup_port(struct apple_pcie *pcie, > > /* Deassert PERST# */ > rmw_set(PORT_PERST_OFF, port->base + PORT_PERST); > - gpiod_set_value(reset, 0); > + gpiod_set_value_cansleep(reset, 0); > > /* Wait for 100ms after PERST# deassertion (PCIe r5.0, 6.6.1) */ > msleep(100); Otherwise: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.