Re: [PATCH 5.10-stable] gpio: mvebu: fix pwm .get_state period calculation

[Baruch Siach <baruch@tkos.co.il>]

Hi Uwe,

Thanks for your review.

On Tue, Jan 26 2021, Uwe Kleine-König wrote:
> On Tue, Jan 26, 2021 at 11:00:11AM +0200, Baruch Siach wrote:
>> commit e73b0101ae5124bf7cd3fb5d250302ad2f16a416 upstream.
>> 
>> The period is the sum of on and off values. That is, calculate period as
>> 
>>   ($on + $off) / clkrate
>> 
>> instead of
>> 
>>   $off / clkrate - $on / clkrate
>> 
>> that makes no sense.
>> 
>> Reported-by: Russell King <linux@armlinux.org.uk>
>> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support")
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
>
> Doesn't this need something like:
>
> 	[baruch: Backported to 5.10]
>
> plus a new S-o-B?

I could not find this requirement in the stable-kernel-rules.rst (Option
3) text.

Greg, should I resend the patch with another SoB?

Thanks,
baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -