From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA3AC433E0 for ; Wed, 27 Jan 2021 13:10:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 03F46207B1 for ; Wed, 27 Jan 2021 13:10:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238268AbhA0NJz convert rfc822-to-8bit (ORCPT ); Wed, 27 Jan 2021 08:09:55 -0500 Received: from guitar.tcltek.co.il ([192.115.133.116]:58824 "EHLO mx.tkos.co.il" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238157AbhA0NHn (ORCPT ); Wed, 27 Jan 2021 08:07:43 -0500 Received: from tarshish (unknown [10.0.8.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx.tkos.co.il (Postfix) with ESMTPS id 095094403E5; Wed, 27 Jan 2021 15:06:56 +0200 (IST) References: <20210126180650.xsrycbnwzu4lzl55@pengutronix.de> User-agent: mu4e 1.4.14; emacs 27.1 From: Baruch Siach To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Greg Kroah-Hartman Cc: stable@vger.kernel.org, Russell King , Bartosz Golaszewski Subject: Re: [PATCH 5.10-stable] gpio: mvebu: fix pwm .get_state period calculation In-reply-to: <20210126180650.xsrycbnwzu4lzl55@pengutronix.de> Date: Wed, 27 Jan 2021 15:06:55 +0200 Message-ID: <87im7iy1e8.fsf@tarshish> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Hi Uwe, Thanks for your review. On Tue, Jan 26 2021, Uwe Kleine-König wrote: > On Tue, Jan 26, 2021 at 11:00:11AM +0200, Baruch Siach wrote: >> commit e73b0101ae5124bf7cd3fb5d250302ad2f16a416 upstream. >> >> The period is the sum of on and off values. That is, calculate period as >> >> ($on + $off) / clkrate >> >> instead of >> >> $off / clkrate - $on / clkrate >> >> that makes no sense. >> >> Reported-by: Russell King >> Reviewed-by: Uwe Kleine-König >> Fixes: 757642f9a584e ("gpio: mvebu: Add limited PWM support") >> Signed-off-by: Baruch Siach >> Signed-off-by: Bartosz Golaszewski > > Doesn't this need something like: > > [baruch: Backported to 5.10] > > plus a new S-o-B? I could not find this requirement in the stable-kernel-rules.rst (Option 3) text. Greg, should I resend the patch with another SoB? Thanks, baruch -- ~. .~ Tk Open Systems =}------------------------------------------------ooO--U--Ooo------------{= - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -