From: Thomas Gleixner <tglx@linutronix.de>
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>,
Huacai Chen <chenhuacai@gmail.com>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@loongson.cn>,
stable@vger.kernel.org, Yinbo Zhu <zhuyinbo@loongson.cn>
Subject: Re: [PATCH] irqchip/loongson-liointc: Support to set IRQ_TYPE_EDGE_BOTH
Date: Thu, 03 Apr 2025 17:48:52 +0200 [thread overview]
Message-ID: <87jz81uty3.ffs@tglx> (raw)
In-Reply-To: <20250402092500.514305-1-chenhuacai@loongson.cn>
On Wed, Apr 02 2025 at 17:25, Huacai Chen wrote:
> Some peripheral subsystems request IRQ_TYPE_EDGE_BOTH interrupt type and
> report request failures on LIOINTC. To avoid such failures we support to
> set IRQ_TYPE_EDGE_BOTH type on LIOINTC, by setting LIOINTC_REG_INTC_EDGE
> to true and keep LIOINTC_REG_INTC_POL as is.
That's broken because it will either trigger on the rising or the
falling edge depending on the setting of LIOINTC_REG_INTC_POL.
But it won't trigger on both. So no, you cannot claim that this fixes
anything.
Thanks,
tglx
next prev parent reply other threads:[~2025-04-03 15:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 9:25 [PATCH] irqchip/loongson-liointc: Support to set IRQ_TYPE_EDGE_BOTH Huacai Chen
2025-04-03 15:48 ` Thomas Gleixner [this message]
2025-04-06 9:46 ` Huacai Chen
2025-04-06 10:18 ` Thomas Gleixner
2025-04-06 12:46 ` Huacai Chen
2025-04-06 14:19 ` Thomas Gleixner
2025-04-08 12:37 ` Huacai Chen
2025-04-08 16:05 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jz81uty3.ffs@tglx \
--to=tglx@linutronix.de \
--cc=chenhuacai@gmail.com \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=loongarch@lists.linux.dev \
--cc=stable@vger.kernel.org \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).