From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF0E24E4B1;
	Thu,  3 Apr 2025 15:48:54 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1743695336; cv=none; b=m8V1D4pXLnGWxATrBzHgHMjuD3EWV5YKuquO4EaeDnG6AGd3jy6GewgMUFvbFi6+ivFMWnQArbr1Cnmb2wfSj0iWDybJT8XDRLtsNgVlIOrjyNq3rjlwoCIhfMi8zV/KijetmXB3ZGl+3WB+KCahjusw49x5Qz+PiicHPjSRfzs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1743695336; c=relaxed/simple;
	bh=IyhGAuZ1M1UhhKEFOifJmLUL71CeOYd1aWvREsqk1fw=;
	h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID:
	 MIME-Version:Content-Type; b=pIVx31GUeOw0MXeeIjt/2cLtNHGPKnArkGAdZOmQJUzvwVVN7K8B1z10P6fA8pz5MAZCEkuyMFgpBv2mhr+zkAy1s8rrJYicSs5szwjM6i3aGb9FhYIDwZor8VOeC3htCzrgTM6elfUwOmU7Ca6jVEM9zzfbzHwLURnKUcl5fn8=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=KmbGUXIt; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=a6Zsce6/; arc=none smtp.client-ip=193.142.43.55
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de
Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="KmbGUXIt";
	dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="a6Zsce6/"
From: Thomas Gleixner <tglx@linutronix.de>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020; t=1743695333;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TRXuTnqZuKLmYdUAaHIN/9JYCVB2WRD59cR8duNwERU=;
	b=KmbGUXIt6TR6J9JwRySB41nKyT3fdlCZ8DDENXdWgMXx594YGivph479pg3SrqtKtP4vbL
	DCCur0zQ2IWVnMo6jAanbeTDBqGXVrl8csnrOHHrLCivXMkhjM435zWQUg6OzHJAgHagTI
	iWmc9eMKING/LNwkCQLrSC1y79fc7hRxzF4RNUaIVeurO48wukJb1KFw66BwJIqZh2840g
	f2H6+7x+Ly9THiszqgFT6YgQRcvrr19Xq8Rz3Jzsig34+zmkmX46qjk8yqtZw5LIzsSGK5
	0SIym8IJktR/AamUdi51Rmsk4d//duNQdSlIvRAR504V4KfcOb17gUSDM0D1uA==
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de;
	s=2020e; t=1743695333;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=TRXuTnqZuKLmYdUAaHIN/9JYCVB2WRD59cR8duNwERU=;
	b=a6Zsce6/qaIAFwe6G7iZDWlz3d+fhgGModIJ7SK1sFYPXsjp2O8W1mENU0x7LgTQtS+8my
	P9+ZU6Z9i5d/a6CA==
To: Huacai Chen <chenhuacai@loongson.cn>
Cc: loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, Xuefeng Li
 <lixuefeng@loongson.cn>, Huacai Chen <chenhuacai@gmail.com>, Jiaxun Yang
 <jiaxun.yang@flygoat.com>, Huacai Chen <chenhuacai@loongson.cn>,
 stable@vger.kernel.org, Yinbo Zhu <zhuyinbo@loongson.cn>
Subject: Re: [PATCH] irqchip/loongson-liointc: Support to set
 IRQ_TYPE_EDGE_BOTH
In-Reply-To: <20250402092500.514305-1-chenhuacai@loongson.cn>
References: <20250402092500.514305-1-chenhuacai@loongson.cn>
Date: Thu, 03 Apr 2025 17:48:52 +0200
Message-ID: <87jz81uty3.ffs@tglx>
Precedence: bulk
X-Mailing-List: stable@vger.kernel.org
List-Id: <stable.vger.kernel.org>
List-Subscribe: <mailto:stable+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:stable+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain

On Wed, Apr 02 2025 at 17:25, Huacai Chen wrote:
> Some peripheral subsystems request IRQ_TYPE_EDGE_BOTH interrupt type and
> report request failures on LIOINTC. To avoid such failures we support to
> set IRQ_TYPE_EDGE_BOTH type on LIOINTC, by setting LIOINTC_REG_INTC_EDGE
> to true and keep LIOINTC_REG_INTC_POL as is.

That's broken because it will either trigger on the rising or the
falling edge depending on the setting of LIOINTC_REG_INTC_POL.

But it won't trigger on both. So no, you cannot claim that this fixes
anything.

Thanks,

        tglx