From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from devils.ext.ti.com ([198.47.26.153]:49172 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754047AbbJNPse (ORCPT ); Wed, 14 Oct 2015 11:48:34 -0400 From: Felipe Balbi To: Jassi Brar CC: Jaswinder Singh , "linux-usb@vger.kernel.org" , Subject: Re: [PATCH] usb: gadget: function: acm: return zlp for OUT setup In-Reply-To: References: <1444834590-25759-1-git-send-email-jassisinghbrar@gmail.com> <87mvvlbi1f.fsf@saruman.tx.rr.com> Date: Wed, 14 Oct 2015 10:48:28 -0500 Message-ID: <87k2qpbgdv.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Jassi Brar writes: > On Wed, Oct 14, 2015 at 8:42 PM, Felipe Balbi wrote: >> >> Hi, >> >> jaswinder.singh@linaro.org writes: >>> From: Jassi Brar >>> >>> We must return 0 for any OUT setup request, otherwise >>> protocol error may occur. >> >> have you seen any such errors ? >> > Yes. While testing my new udc driver. > > >> Care to describe what problems you have seen and which UDC you were usin= g, >> what's the exact scenario. How have you tested this ? >> > The udc I am writing the driver for is not yet public. To test my > driver at lowest level possible, I use 'usbmon' to capture and analyze > traffic since I don't have any hardware probe. > > I see the following on gadget side > ------- > configfs-gadget gadget: non-core control req21.20 v0000 i0001 l7 > configfs-gadget gadget: acm ttyGS0 req21.20 v0000 i0001 l7 > configfs-gadget gadget: acm ttyGS0 completion, err -71 > ------- > > and the following on host side usbmon capture > ------- > ffff88041ed01f00 540296433 S Co:3:023:0 s 21 20 0000 0001 0007 7 =3D > 80250000 000008 > ffff88041ed01f00 540296790 C Co:3:023:0 -71 0 > ------- and you did you even consider this could be a bug in your new UDC driver at all ? This works fine with other UDCs. How far are you in developing this new UDC driver ? Did you run USBCV at all ? Are you sure you're implementing EP0 handling correctly ? What sort of tests have you done with this UDC ? Is it working with testusb against a known good host (EHCI and XHCI should be good for that) ? =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWHnlNAAoJEIaOsuA1yqREhq4P/RWlyhFA65WAocjUaixaFmWA 0I1x7YbimTGwxN4U8CSZPKVlV0j4BR2Fqn9CibLjIzhcrJi7AOcRUXco/bDUFGSe +VkLqDWXvtirltWkz3tYmK6RCIwgsmzzP1cTXblwHZh0MU6SWhgmJY+F+d0owUTH OX1VndkDthwFQLk2jeL4pRZVi59tcOmW2HxEQjgbdOpilc5nUjmfnDeiT+bk2SPx bZfhtxU3Zi5m110GPH0ZqNU9npPHcjKqxPMaqugU9NEQ04WMeQQlr4i+W/2ZWmWS jp3G2jHMpK21tP0AVJAqkWERfcYfNuop4G0KgygvluAaiLPOVFnABbmjb/qVwljK /XAwNsTMiOuM66xZeEYlAMjTtXC+5v6oWhS2dVFkQhhaTezgxWenGWwylLkfGu4e G0oq1fH2KLpLyw76W0sjayTqozfIZJtKYNU3QUZmO+BFKsqJpPEl//NXDcxpaldw UaA7g2qnb1Puvmjv2AtS5tKVNMaWStzPxPb7cALnvvE/qWKKOWZHuL9dE/vkycgg SVGMIGATv16R/2nFR2s7Qj+Jm7CHfIRx6Fis25EuYvLXMfceLL34Ss8kNM+T12uN fvW0pxp0c7Q0LBnF9DFtlADF27FDi7YKdDwR51G3Yj/bPsEclg8q5CvrDF6QCmsM vUT+a8bT1565G8RN9bcJ =E6Mg -----END PGP SIGNATURE----- --=-=-=--