From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43CB4318BB5 for ; Mon, 27 Apr 2026 11:51:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=195.135.223.130 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777290687; cv=none; b=Yez2jCxFS8gb8AiAEiNgaJ0cywAFiWzQjcd9VjDYVA0NjtMFgxsZliQY0SAMQVJzcWRG4PWDD+FGa/iNQgLnsGU+b6GLd7UscwZO+4LuCJfxyZSRvxltRdifsfpNS+MJ6xSTy2Hml1Tnfw7RLRCYm0y8C2a/Kjc2iAWt2+sOCvk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777290687; c=relaxed/simple; bh=Y24ALd/5e6geTzEKfrJ1lUSzzslxkSkEt9FfkXeqwLA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ZxCWtyQSvfRk7ke/plFkZtiwfIDjn8vXpthNvmbEBxjZl9GyaO4gYiyB3qyYC1ZfhhUlmC4zLwjMuRwpDDW7ASFV1c/qFk84H6fvMeQaN13VIe2GjWhLUAhQ0fV46MKA5ePQ4ktw6SKJ/cidv6mHIQ01KxVHRZ1EkxR+m+/56+U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=F9rqk8W+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=AL8SlN+5; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b=F9rqk8W+; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b=AL8SlN+5; arc=none smtp.client-ip=195.135.223.130 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="F9rqk8W+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AL8SlN+5"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="F9rqk8W+"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="AL8SlN+5" Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 72A036A8FE; Mon, 27 Apr 2026 11:51:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777290684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XjpLoFbAc5eqIj0Rr1ipV3Z02rKGDjvcREaLEvPnqBA=; b=F9rqk8W+jdZIw0uiL1Rf0Hp9MqG1TXbOHzQ72TSeOnl8sEwJN5BFSpCPvTXqAxg8Vf2hNt 1hkpiS9IWMv9lh11IRn4bblkc2CXW8axP83R035K37nIIdI14Cx8+yZ29uMh8pNedsk1aW beIEaoeYRWzi+V618oQzuuaGdFLwqTc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777290684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XjpLoFbAc5eqIj0Rr1ipV3Z02rKGDjvcREaLEvPnqBA=; b=AL8SlN+5XxWd5mYPOB7vR/0jIiwYu1DK7kTILaJ9WVCfBptH51tN0m+aKGB4R2ZqrE+k/l i14InzsnsfPVC6BA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=F9rqk8W+; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=AL8SlN+5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1777290684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XjpLoFbAc5eqIj0Rr1ipV3Z02rKGDjvcREaLEvPnqBA=; b=F9rqk8W+jdZIw0uiL1Rf0Hp9MqG1TXbOHzQ72TSeOnl8sEwJN5BFSpCPvTXqAxg8Vf2hNt 1hkpiS9IWMv9lh11IRn4bblkc2CXW8axP83R035K37nIIdI14Cx8+yZ29uMh8pNedsk1aW beIEaoeYRWzi+V618oQzuuaGdFLwqTc= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1777290684; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XjpLoFbAc5eqIj0Rr1ipV3Z02rKGDjvcREaLEvPnqBA=; b=AL8SlN+5XxWd5mYPOB7vR/0jIiwYu1DK7kTILaJ9WVCfBptH51tN0m+aKGB4R2ZqrE+k/l i14InzsnsfPVC6BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 3285F593B0; Mon, 27 Apr 2026 11:51:24 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id xOElC7xN72mScQAAD6G6ig (envelope-from ); Mon, 27 Apr 2026 11:51:24 +0000 Date: Mon, 27 Apr 2026 13:51:23 +0200 Message-ID: <87lde8zkn8.wl-tiwai@suse.de> From: Takashi Iwai To: =?ISO-8859-1?Q?C=E1ssio?= Gabriel Cc: Takashi Iwai , Jaroslav Kysela , Youngjun Lee , linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ALSA: usb-audio: Fix UAC3 cluster descriptor size check In-Reply-To: <20260424-alsa-usb-uac3-cluster-size-v1-1-99a5808898a3@gmail.com> References: <20260424-alsa-usb-uac3-cluster-size-v1-1-99a5808898a3@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/30.2 Mule/6.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Spamd-Result: default: False [-3.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; MID_CONTAINS_FROM(1.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; FREEMAIL_TO(0.00)[gmail.com]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_COUNT_TWO(0.00)[2]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Queue-Id: 72A036A8FE X-Spam-Flag: NO X-Spam-Score: -3.51 X-Spam-Level: On Fri, 24 Apr 2026 23:50:10 +0200, Cássio Gabriel wrote: > > The UAC3 cluster descriptor length check in > snd_usb_get_audioformat_uac3()was added to > make sure that the buffer is large enough for > a struct uac3_cluster_header_descriptor before the > returned data is cast and used. > > However, the check uses sizeof(cluster), where cluster > is a pointer, not the size of the descriptor header. > This makes the validation depend on the architecture > pointer size and does not match the intended object size. > > Check against sizeof(*cluster) instead. > > Fixes: fb4e2a6e8f28 ("ALSA: usb-audio: Fix out-of-bounds read in snd_usb_get_audioformat_uac3()") > Cc: stable@vger.kernel.org > Signed-off-by: Cássio Gabriel Applied now. Thanks. Takashi