From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 523B91FBEB7 for ; Fri, 3 Jan 2025 18:00:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735927244; cv=none; b=ODnqHDJAs7hozpHio7Bnkcg836Af1X30m7JXlKjMA3gz2FmwX9cqqS5p+J2b0hcYlNddi1RjcQxVR81RVg29eb+h/kKPGo7r9Pz8G7uZuNMxm3eBNKYal0QGyO/6f4SD5OR8htn5QzC5LwHAX01D6+CRe44MEC9tiWjx8efnI54= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735927244; c=relaxed/simple; bh=y8DtExH10YY8xlpl4eYpAw2CrqzlWu7uIt4ke9vXveA=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=QpJZ/ro5FDIbC9tY5t+2y2oyh5jwpiRPghWOMkilUk5EEaSasAJxVyNu5dh7tQlpCkByHib0lLE8Gk6EJkos5BqKthmcYeWvJDygXPWzFsXxGSU2bXgvrEjOKBTK+s+/aYkAY111kEFJ0tTDnmyGKEKbbUiECgCVzxhOQR9Bsx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WLeNCILj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WLeNCILj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A9514C4CECE; Fri, 3 Jan 2025 18:00:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1735927243; bh=y8DtExH10YY8xlpl4eYpAw2CrqzlWu7uIt4ke9vXveA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=WLeNCILjJEpj9L16rGoiK6Yo1I9pPS1WsZC57R8KrePpTPcinwBsogcvf+Jy+S3fr QTeZVfvllyVh2/cacJuDEnkBdYDWwF8j9Uv9UMk22LAZn2KDjx5Ge4zGCzSAuLSpqF p/Teb/xC4GMayN8IVH/ajNjhd6ZwY7dApKESzjsjArTheYNLkuBY/6bQxAgo5Lv1wX cPRYRDDYJ5jpDke7XG4yxFl/kehkiMWu7tfTCFrJkN+W9746YNxvLsW/1Hu4BOUK9g yEwoL4wzKvyKG56swEoYDIS3RsMJYVKtUGGoroXKB8XVbv+Dd2pCYGsc2eCrWAlHOB ZNu0KJIFSZesg== Received: from sofa.misterjones.org ([185.219.108.64] helo=wait-a-minute.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tTlyT-008lTV-Lc; Fri, 03 Jan 2025 18:00:41 +0000 Date: Fri, 03 Jan 2025 18:00:43 +0000 Message-ID: <87ldvrrd4k.wl-maz@kernel.org> From: Marc Zyngier To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , Mark Rutland , Mark Brown , stable@vger.kernel.org Subject: Re: [PATCH] arm64: Filter out SVE hwcaps when FEAT_SVE isn't implemented In-Reply-To: References: <20250103142635.1759674-1-maz@kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org, will@kernel.org, mark.rutland@arm.com, broonie@kernel.org, stable@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Fri, 03 Jan 2025 17:39:39 +0000, Catalin Marinas wrote: > > On Fri, Jan 03, 2025 at 05:20:05PM +0000, Catalin Marinas wrote: > > On Fri, Jan 03, 2025 at 02:26:35PM +0000, Marc Zyngier wrote: > > > @@ -3022,6 +3027,13 @@ static const struct arm64_cpu_capabilities arm64_features[] = { > > > .matches = match, \ > > > } > > > > > > +#define HWCAP_CAP_MATCH_ID(match, reg, field, min_value, cap_type, cap) \ > > > + { \ > > > + __HWCAP_CAP(#cap, cap_type, cap) \ > > > + HWCAP_CPUID_MATCH(reg, field, min_value) \ > > > + .matches = match, \ > > > + } > > > > Do we actually need this macro? > > Ignore me, we still need this macro as HWCAP_CAP_MATCH does not take all > the arguments. Maybe not the read_scoped_sysreg() change though. Ah, I just replied to your earlier email. Agreed on avoiding the read_scoped_sysreg() change, replacing it with system_supports_sve(). I'll respin the change now. M. -- Without deviation from the norm, progress is not possible.