Re: [PATCH] wifi: rtl8xxxu: add more missing rtl8192cu USB IDs

[Kalle Valo <kvalo@kernel.org>]

Hans de Goede <hdegoede@redhat.com> writes:

> Hi,
>
> On 9-Dec-24 1:26 AM, Ping-Ke Shih wrote:
>> Hans de Goede <hdegoede@redhat.com> wrote:
>>> Hi,
>>>
>>> On 18-Nov-24 3:23 AM, Ping-Ke Shih wrote:
>>>> Hans de Goede <hdegoede@redhat.com> wrote:
>>>>
>>>>> The rtl8xxxu has all the rtl8192cu USB IDs from rtlwifi/rtl8192cu/sw.c
>>>>> except for the following 10, add these to the untested section so they
>>>>> can be used with the rtl8xxxu as the rtl8192cu are well supported.
>>>>>
>>>>> This fixes these wifi modules not working on distributions which have
>>>>> disabled CONFIG_RTL8192CU replacing it with CONFIG_RTL8XXXU_UNTESTED,
>>>>> like Fedora.
>>>>>
>>>>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2321540
>>>>> Cc: stable@vger.kernel.org
>>>>> Cc: Peter Robinson <pbrobinson@gmail.com>
>>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>>> Reviewed-by: Peter Robinson <pbrobinson@gmail.com>
>>>>
>>>> 1 patch(es) applied to rtw-next branch of rtw.git, thanks.
>>>>
>>>> 31be3175bd7b wifi: rtl8xxxu: add more missing rtl8192cu USB IDs
>>>
>>> Thank you for merging this, since this is a bugfix patch, see e.g. :
>>>
>>> https://bugzilla.redhat.com/show_bug.cgi?id=2321540
>>>
>>> I was expecting this patch to show up in 6.13-rc1 but it does
>>> not appear to be there.
>>>
>>> Can you please include this in a fixes-pull-request to the network
>>> maintainer so that gets added to a 6.13-rc# release soon and then
>>> can be backported to various stable kernels ?
>>>
>> 
>> This patch stays in rtw.git and 6.14 will have it, and then drain to stable
>> trees. For the redhat users, could you ask the distro maintainer to take this
>> patch ahead?
>
> That is not how things are supposed to work. You are supposed to have a fixes
> tree/branch and a next tree/branch and fixes should be send out ASAP.

Please understand that we are more or less volunteers and working with
limited time.

> Ideally you would have already send this out as a fixes pull-request for
> 6.12 but waiting till 6.14 really is not acceptable IMHO.

If you have an important fix please document that somehow, for example
"[PATCH wireless]" or "[PATCH v6.13]". If there's nothing like that most
likely the patch goes to -next, we (in wireless) don't take every fix to
-rc.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches