From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F1C5119E for ; Fri, 24 Nov 2023 23:16:22 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A00D121CD1; Sat, 25 Nov 2023 07:16:21 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 6148C1384C; Sat, 25 Nov 2023 07:16:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id NSxNFkWfYWUwOAAAD6G6ig (envelope-from ); Sat, 25 Nov 2023 07:16:21 +0000 Date: Sat, 25 Nov 2023 08:16:20 +0100 Message-ID: <87leampakb.wl-tiwai@suse.de> From: Takashi Iwai To: Greg Kroah-Hartman Cc: stable@vger.kernel.org, patches@lists.linux.dev, Philippe Perrot , "Geoffrey D. Bennett" , Takashi Iwai , Sasha Levin Subject: Re: [PATCH 6.6 088/530] ALSA: scarlett2: Move USB IDs out from device_info struct In-Reply-To: <20231124172030.757235707@linuxfoundation.org> References: <20231124172028.107505484@linuxfoundation.org> <20231124172030.757235707@linuxfoundation.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: Authentication-Results: smtp-out1.suse.de; none X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-4.00 / 50.00]; REPLY(-4.00)[] X-Spam-Score: -4.00 X-Rspamd-Queue-Id: A00D121CD1 On Fri, 24 Nov 2023 18:44:14 +0100, Greg Kroah-Hartman wrote: > > 6.6-stable review patch. If anyone has any objections, please let me know. > > ------------------ > > From: Geoffrey D. Bennett > > [ Upstream commit d98cc489029dba4d99714c2e8ec4f5ba249f6851 ] > > By moving the USB IDs from the device_info struct into > scarlett2_devices[], that will allow for devices with different > USB IDs to share the same device_info. > > Tested-by: Philippe Perrot > Signed-off-by: Geoffrey D. Bennett > Link: https://lore.kernel.org/r/8263368e8d49e6fcebc709817bd82ab79b404468.1694705811.git.g@b4.vu > Signed-off-by: Takashi Iwai > Signed-off-by: Sasha Levin As already mentioned at http://lore.kernel.org/r/87edgkpiig.wl-tiwai@suse.de this patch makes little sense as a stable update. It's a part of the code rewrite series, and no real fix. Better to drop for avoid confusions. Ditto for 6.5 and older kernels. thanks, Takashi