From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, stable@vger.kernel.org,
Jingoo Han <jingoohan1@gmail.com>
Subject: Re: [PATCH] PCI: Fix bit definitions for LNKCAP2 register
Date: Tue, 07 Aug 2018 11:20:33 +0300 [thread overview]
Message-ID: <87lg9ia8q6.fsf@linux.intel.com> (raw)
In-Reply-To: <20180806182327.GA30691@bhelgaas-glaptop.roam.corp.google.com>
Hi,
Bjorn Helgaas <helgaas@kernel.org> writes:
> On Fri, Aug 03, 2018 at 09:51:20AM +0300, Felipe Balbi wrote:
>> Even thhough commit b891b4dc1eed claimed that original bit definitions
>> were wrong, that's not really the case. After verifying PCI
>> Specification Revisions 3.0, 3.1 and 4.0, Link Capabilites 2
>> Register's bit definitions were always starting from Bit 0.
>>
>> This has been causing issues reporting correct link speeds on sysfs.
>
> Can you elaborate on this a bit? b891b4dc1eed still looks correct to
> me. I'm looking at PCIe r4.0, sec 7.5.3.18, where it shows:
>
> bit 0 RsvdP
> bits 7:1 Supported Link Speeds Vector
I had missed this detail, actually. It was a misinterpretation of the
spec. Sorry for the noise.
--
balbi
next prev parent reply other threads:[~2018-08-07 10:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-03 6:51 [PATCH] PCI: Fix bit definitions for LNKCAP2 register Felipe Balbi
2018-08-06 18:23 ` Bjorn Helgaas
2018-08-07 8:20 ` Felipe Balbi [this message]
2018-08-07 18:18 ` Jingoo Han
2018-08-07 20:13 ` Bjorn Helgaas
2018-08-08 6:30 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg9ia8q6.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).