From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: ville.syrjala@linux.intel.com, linux-usb@vger.kernel.org
Cc: stable@vger.kernel.org, "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit"
Date: Mon, 03 Oct 2016 19:08:43 +0300 [thread overview]
Message-ID: <87lgy5za7o.fsf@linux.intel.com> (raw)
In-Reply-To: <1475504282-13268-1-git-send-email-ville.syrjala@linux.intel.com>
Hi,
ville.syrjala@linux.intel.com writes:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> This reverts commit 55a0237f8f47957163125e20ee9260538c5c341c.
>
> commit 55a0237f8f47 ("usb: dwc3: gadget: use allocated/queued reqs for
> LST bit") causes my BYT FFRD8 with g_ether to behave poorly. ssh/scp
> is very sluggish and can even stall entirely. Revert cures it.
>
> Cc: Felipe Balbi <felipe.balbi@linux.intel.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reverting that commit is not the best idea. Let's start with the usual:
- Kernel version
- dmesg on both sides (host and device)
- dwc3 tracepoints:
# mkdir -p /t
# mount -t tracefs none /t
# echo 8192 > /t/buffer_size_kb
# echo 1 > /t/events/dwc3/enable
# echo 0 > /t/events/dwc3/dwc3_readl/enable
# echo 0 > /t/events/dwc3/dwc3_writel/enable
This should be enough to tell me what's really going on.
--
balbi
next prev parent reply other threads:[~2016-10-03 16:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 14:18 [PATCH] Revert "usb: dwc3: gadget: use allocated/queued reqs for LST bit" ville.syrjala
2016-10-03 16:08 ` Felipe Balbi [this message]
2016-10-04 7:43 ` Felipe Balbi
2016-10-04 8:38 ` Ville Syrjälä
2016-10-04 12:23 ` Felipe Balbi
2016-10-04 13:20 ` Ville Syrjälä
2016-10-04 14:03 ` Felipe Balbi
2016-10-06 7:36 ` Felipe Balbi
2016-10-06 9:08 ` Ville Syrjälä
2016-10-27 15:40 ` Ville Syrjälä
2016-10-28 10:16 ` Felipe Balbi
2016-10-28 16:33 ` Ville Syrjälä
2016-10-31 18:51 ` David Miller
2016-11-01 11:30 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgy5za7o.fsf@linux.intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=linux-usb@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).