From: Vinicius Costa Gomes <vinicius.gomes@intel.com>
To: Daniel J Blueman <daniel@quora.org>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
Vinod Koul <vkoul@kernel.org>, Dave Jiang <dave.jiang@intel.com>
Cc: Daniel J Blueman <daniel@quora.org>,
Scott Hamilton <scott.hamilton@eviden.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] idxd: Fix Intel Data Streaming Accelerator double-free on error path
Date: Tue, 27 Jan 2026 08:50:37 -0800 [thread overview]
Message-ID: <87ms1z6luq.fsf@intel.com> (raw)
In-Reply-To: <20260127075210.3584849-1-daniel@quora.org>
Hi Daniel,
Daniel J Blueman <daniel@quora.org> writes:
> During IDXD driver probe unwind from an earlier resource allocation
> failure, multiple use-after-free codepaths are taken leading to attempted
> double-free of ID allocator entries and memory allocations, eg:
>
> ida_free called for id=64 which is not allocated.
> WARNING: lib/idr.c:594 at ida_free+0x1af/0x1f4, CPU#900: kworker/900:1/11863
> ...
> Call Trace:
> <TASK>
> ? ida_destroy+0x258/0x258
> idxd_pci_probe_alloc+0x342e/0x348c
> ? multi_u64_to_bmap+0xc9/0xc9
> ? queued_read_unlock+0x1e/0x1e
> ? __schedule+0x2e43/0x2ee6
> ? idxd_reset_done+0x12ca/0x12ca
> idxd_pci_probe+0x15/0x17
> ...
>
> Fix this by releasing these allocations only after use and once.
>
> Validated on 8 socket and 16 socket (XNC node controller) Intel Saphire
> Rapids XCC systems with no KASAN, Kmemleak or lockdep reports.
Can you confirm that you still see this issue after you apply the series
I sent last week?
Cheers,
--
Vinicius
prev parent reply other threads:[~2026-01-27 16:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-27 7:52 [PATCH] idxd: Fix Intel Data Streaming Accelerator double-free on error path Daniel J Blueman
2026-01-27 16:15 ` Dave Jiang
2026-01-27 16:50 ` Vinicius Costa Gomes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ms1z6luq.fsf@intel.com \
--to=vinicius.gomes@intel.com \
--cc=daniel@quora.org \
--cc=dave.jiang@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=scott.hamilton@eviden.com \
--cc=stable@vger.kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox