* [PATCH] ALSA: hda/realtek: extend quirks for Clevo V5[46]0
@ 2024-09-03 12:49 Marek Marczykowski-Górecki
2024-09-03 16:08 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Marek Marczykowski-Górecki @ 2024-09-03 12:49 UTC (permalink / raw)
To: linux-kernel
Cc: Marek Marczykowski-Górecki, stable, Michał Kopeć,
Jaroslav Kysela, Takashi Iwai, Kailang Yang, Stefan Binding,
Simon Trimmer, Athaariq Ardhiansyah, Richard Fitzgerald,
open list:SOUND
The mic in those laptops suffers too high gain resulting in mostly (fan
or else) noise being recorded. In addition to the existing fixup about
mic detection, apply also limiting its boost. While at it, extend the
quirk to also V5[46]0TNE models, which have the same issue.
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Cc: <stable@vger.kernel.org>
---
Cc: Michał Kopeć <michal.kopec@3mdeb.com>
---
sound/pci/hda/patch_realtek.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 588738ce7380..01e2414b8839 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7637,6 +7637,7 @@ enum {
ALC287_FIXUP_LENOVO_14ARP8_LEGION_IAH7,
ALC287_FIXUP_LENOVO_SSID_17AA3820,
ALCXXX_FIXUP_CS35LXX,
+ ALC245_FIXUP_CLEVO_NOISY_MIC,
};
/* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -9970,6 +9971,12 @@ static const struct hda_fixup alc269_fixups[] = {
.type = HDA_FIXUP_FUNC,
.v.func = cs35lxx_autodet_fixup,
},
+ [ALC245_FIXUP_CLEVO_NOISY_MIC] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc269_fixup_limit_int_mic_boost,
+ .chained = true,
+ .chain_id = ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE,
+ },
};
static const struct snd_pci_quirk alc269_fixup_tbl[] = {
@@ -10619,7 +10626,8 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1558, 0xa600, "Clevo NL50NU", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0xa650, "Clevo NP[567]0SN[CD]", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0xa671, "Clevo NP70SN[CDE]", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
- SND_PCI_QUIRK(0x1558, 0xa763, "Clevo V54x_6x_TU", ALC256_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1558, 0xa741, "Clevo V54x_6x_TNE", ALC245_FIXUP_CLEVO_NOISY_MIC),
+ SND_PCI_QUIRK(0x1558, 0xa763, "Clevo V54x_6x_TU", ALC245_FIXUP_CLEVO_NOISY_MIC),
SND_PCI_QUIRK(0x1558, 0xb018, "Clevo NP50D[BE]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0xb019, "Clevo NH77D[BE]Q", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1558, 0xb022, "Clevo NH77D[DC][QW]", ALC293_FIXUP_SYSTEM76_MIC_NO_PRESENCE),
--
2.46.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ALSA: hda/realtek: extend quirks for Clevo V5[46]0
2024-09-03 12:49 [PATCH] ALSA: hda/realtek: extend quirks for Clevo V5[46]0 Marek Marczykowski-Górecki
@ 2024-09-03 16:08 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2024-09-03 16:08 UTC (permalink / raw)
To: Marek Marczykowski-Górecki
Cc: linux-kernel, stable, Michał Kopeć, Jaroslav Kysela,
Takashi Iwai, Kailang Yang, Stefan Binding, Simon Trimmer,
Athaariq Ardhiansyah, Richard Fitzgerald, open list:SOUND
On Tue, 03 Sep 2024 14:49:31 +0200,
Marek Marczykowski-Górecki wrote:
>
> The mic in those laptops suffers too high gain resulting in mostly (fan
> or else) noise being recorded. In addition to the existing fixup about
> mic detection, apply also limiting its boost. While at it, extend the
> quirk to also V5[46]0TNE models, which have the same issue.
>
> Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> Cc: <stable@vger.kernel.org>
Thanks, applied now.
Takashi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-09-03 16:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-03 12:49 [PATCH] ALSA: hda/realtek: extend quirks for Clevo V5[46]0 Marek Marczykowski-Górecki
2024-09-03 16:08 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox