From: Eric Anholt <eric@anholt.net>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Arnd Bergmann <arnd@arndb.de>,
olof@lixom.net, gregkh@linuxfoundation.org
Cc: bcm-kernel-feedback-list@broadcom.com,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, arm@kernel.org,
Stefan Wahren <stefan.wahren@i2se.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs
Date: Mon, 03 Dec 2018 10:59:23 -0800 [thread overview]
Message-ID: <87mupmjv1w.fsf@anholt.net> (raw)
In-Reply-To: <1543862228-3863-1-git-send-email-stefan.wahren@i2se.com>
[-- Attachment #1: Type: text/plain, Size: 882 bytes --]
Stefan Wahren <stefan.wahren@i2se.com> writes:
> The commit b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> introduced a wifi power sequence. Unfortunately the polarity of the reset
> GPIOs were wrong and broke the wifi support on Raspberry Pi 3 B and
> later in 3 B+. This wasn't discovered before since the power sequence
> takes only effect in case the relevant MMC driver is compiled as a module.
>
> Fixes: b1b8f45b3130 ("ARM: dts: bcm2837: Add missing GPIOs of Expander")
> Cc: stable@vger.kernel.org
> Reported-by: Matthias Lueschner <lueschem@gmail.com>
> Link: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911443
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
>
> Hi, i like to have this included in 4.20 if possible.
Reviewed-by: Eric Anholt <eric@anholt.net>
Florian, would you be able to pick this directly to a -fixes branch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-12-03 18:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 18:37 [PATCH] ARM: dts: bcm2837: Fix polarity of wifi reset GPIOs Stefan Wahren
2018-12-03 18:59 ` Eric Anholt [this message]
2018-12-03 19:51 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mupmjv1w.fsf@anholt.net \
--to=eric@anholt.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=olof@lixom.net \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox