* [PATCH v2] ARM: dts: armada-38x: use the new thermal binding
@ 2018-07-03 3:24 Baruch Siach
2018-07-04 13:29 ` Gregory CLEMENT
0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2018-07-03 3:24 UTC (permalink / raw)
To: Jason Cooper, Andrew Lunn, Gregory Clement, Sebastian Hesselbarth
Cc: Miquel Raynal, Russell King, linux-arm-kernel,
Andreas Färber, Baruch Siach, stable
Commit 2f28e4c24b10e (thermal: armada: Clarify control registers
accesses) introduced the new thermal binding. The new binding extends
the second registers field size to 8. Switch to the new binding to fix
thermal reading values. Without this change the fix for errata #132698
introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim
default value) has no effect.
Cc: stable@vger.kernel.org # v4.16+
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
v2:
* Typo fixes (Andreas Färber)
* Add Miquel's review tag
* Minor wording changes
* Cc stable
---
arch/arm/boot/dts/armada-38x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
index 18edc9bc7927..929459c42760 100644
--- a/arch/arm/boot/dts/armada-38x.dtsi
+++ b/arch/arm/boot/dts/armada-38x.dtsi
@@ -547,7 +547,7 @@
thermal: thermal@e8078 {
compatible = "marvell,armada380-thermal";
- reg = <0xe4078 0x4>, <0xe4074 0x4>;
+ reg = <0xe4078 0x4>, <0xe4070 0x8>;
status = "okay";
};
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] ARM: dts: armada-38x: use the new thermal binding
2018-07-03 3:24 [PATCH v2] ARM: dts: armada-38x: use the new thermal binding Baruch Siach
@ 2018-07-04 13:29 ` Gregory CLEMENT
0 siblings, 0 replies; 2+ messages in thread
From: Gregory CLEMENT @ 2018-07-04 13:29 UTC (permalink / raw)
To: Baruch Siach
Cc: Jason Cooper, Andrew Lunn, Sebastian Hesselbarth, Miquel Raynal,
Russell King, linux-arm-kernel, Andreas Färber, stable
Hi Baruch,
On mar., juil. 03 2018, Baruch Siach <baruch@tkos.co.il> wrote:
> Commit 2f28e4c24b10e (thermal: armada: Clarify control registers
> accesses) introduced the new thermal binding. The new binding extends
> the second registers field size to 8. Switch to the new binding to fix
> thermal reading values. Without this change the fix for errata #132698
> introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim
> default value) has no effect.
>
> Cc: stable@vger.kernel.org # v4.16+
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
Applied on mvebu/fixes
Thanks,
Gregory
> ---
> v2:
> * Typo fixes (Andreas Färber)
> * Add Miquel's review tag
> * Minor wording changes
> * Cc stable
> ---
> arch/arm/boot/dts/armada-38x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index 18edc9bc7927..929459c42760 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -547,7 +547,7 @@
>
> thermal: thermal@e8078 {
> compatible = "marvell,armada380-thermal";
> - reg = <0xe4078 0x4>, <0xe4074 0x4>;
> + reg = <0xe4078 0x4>, <0xe4070 0x8>;
> status = "okay";
> };
>
> --
> 2.18.0
>
--
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-04 13:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-03 3:24 [PATCH v2] ARM: dts: armada-38x: use the new thermal binding Baruch Siach
2018-07-04 13:29 ` Gregory CLEMENT
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).