From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail.bootlin.com ([62.4.15.54]:48670 "EHLO mail.bootlin.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752634AbeGDN3i (ORCPT <rfc822;stable@vger.kernel.org>);
        Wed, 4 Jul 2018 09:29:38 -0400
From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
        Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
        Miquel Raynal <miquel.raynal@bootlin.com>,
        Russell King <linux@armlinux.org.uk>,
        linux-arm-kernel@lists.infradead.org,
        Andreas =?utf-8?Q?F=C3=A4rber?= <afaerber@suse.de>,
        stable@vger.kernel.org
Subject: Re: [PATCH v2] ARM: dts: armada-38x: use the new thermal binding
References: <fa45caea9ab04a515805e80b8c02a74a00a908e0.1530588260.git.baruch@tkos.co.il>
Date: Wed, 04 Jul 2018 15:29:37 +0200
In-Reply-To: <fa45caea9ab04a515805e80b8c02a74a00a908e0.1530588260.git.baruch@tkos.co.il>
        (Baruch Siach's message of "Tue, 3 Jul 2018 06:24:20 +0300")
Message-ID: <87muv72kou.fsf@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8BIT
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

Hi Baruch,
 
 On mar., juil. 03 2018, Baruch Siach <baruch@tkos.co.il> wrote:

> Commit 2f28e4c24b10e (thermal: armada: Clarify control registers
> accesses) introduced the new thermal binding. The new binding extends
> the second registers field size to 8. Switch to the new binding to fix
> thermal reading values. Without this change the fix for errata #132698
> introduced in commit 8c0b888f661 (thermal: armada: Change sensors trim
> default value) has no effect.
>
> Cc: stable@vger.kernel.org # v4.16+
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>


Applied on mvebu/fixes

Thanks,

Gregory


> ---
> v2:
>   * Typo fixes (Andreas Färber)
>   * Add Miquel's review tag
>   * Minor wording changes
>   * Cc stable
> ---
>  arch/arm/boot/dts/armada-38x.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/armada-38x.dtsi b/arch/arm/boot/dts/armada-38x.dtsi
> index 18edc9bc7927..929459c42760 100644
> --- a/arch/arm/boot/dts/armada-38x.dtsi
> +++ b/arch/arm/boot/dts/armada-38x.dtsi
> @@ -547,7 +547,7 @@
>  
>  			thermal: thermal@e8078 {
>  				compatible = "marvell,armada380-thermal";
> -				reg = <0xe4078 0x4>, <0xe4074 0x4>;
> +				reg = <0xe4078 0x4>, <0xe4070 0x8>;
>  				status = "okay";
>  			};
>  
> -- 
> 2.18.0
>

-- 
Gregory Clement, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com