From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from canardo.mork.no ([148.122.252.1]:44362 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751312AbcEMQ7b convert rfc822-to-8bit (ORCPT ); Fri, 13 May 2016 12:59:31 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Greg Kroah-Hartman Cc: Oliver Neukum , linux-usb@vger.kernel.org, Subject: Re: [PATCH] cdc-wdm: fix "out-of-sync" due to missing notifications References: <1463153977-19771-1-git-send-email-bjorn@mork.no> Date: Fri, 13 May 2016 18:59:25 +0200 In-Reply-To: <1463153977-19771-1-git-send-email-bjorn@mork.no> (=?utf-8?Q?=22Bj=C3=B8rn?= Mork"'s message of "Fri, 13 May 2016 17:39:37 +0200") Message-ID: <87mvntevwy.fsf@nemi.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: Bjørn Mork writes: > The driver enforces a strict one-to-one relationship between the > received RESPONSE_AVAILABLE notifications and messages read from > the device. At the same time, it will cancel the interrupt URB > when there is no client holding the character device open. Never mind. Forget it. This patch breaks other devices again. The immediate and unconditional reading make them barf. I guess it can be worked around by delaying the flushing until at least one notification is received, but I obviously have to test this theory thoroughly on all devices I have. Bjørn