From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Felipe Balbi <balbi@kernel.org>
Cc: Peter Griffin <peter.griffin@linaro.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, mathias.nyman@intel.com,
gregkh@linuxfoundation.org, lee.jones@linaro.org,
linux-usb@vger.kernel.org, maxime.coquelin@st.com,
patrice.chotard@st.com, stable@vger.kernel.org,
yoshihiro.shimoda.uh@renesas.com
Subject: Re: [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value
Date: Fri, 25 Mar 2016 18:07:09 +0100 [thread overview]
Message-ID: <87mvpmlc5e.fsf@free-electrons.com> (raw)
In-Reply-To: <87mvpm8pfl.fsf@ti.com> (Felipe Balbi's message of "Fri, 25 Mar 2016 18:58:38 +0200")
Hi Felipe,
On ven., mars 25 2016, Felipe Balbi <balbi@kernel.org> wrote:
> Hi,
>
> Peter Griffin <peter.griffin@linaro.org> writes:
>> Otherwise generic-xhci and xhci-platform which have no data get wrongly
>> detected as XHCI_PLAT_TYPE_MARVELL_ARMADA by xhci_plat_type_is().
>>
>> This fixes a regression in v4.5 for STiH407 family SoC's which use the
>> synopsis dwc3 IP, whereby the disable_clk error path gets taken due to
>> wrongly being detected as XHCI_PLAT_TYPE_MARVELL_ARMADA and the hcd never
>> gets added.
>>
>> I suspect this will also fix other dwc3 DT platforms such as Exynos,
>> although I've only tested on STih410 SoC.
>>
>> Fixes: 4efb2f694114 ("usb: host: xhci-plat: add struct xhci_plat_priv")
>> Cc: stable@vger.kernel.org
>> Cc: gregory.clement@free-electrons.com
>> Cc: yoshihiro.shimoda.uh@renesas.com
>> Signed-off-by: Peter Griffin <peter.griffin@linaro.org>
>> ---
>> drivers/usb/host/xhci-plat.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/xhci-plat.h b/drivers/usb/host/xhci-plat.h
>> index 5a2e2e3..529c3c4 100644
>> --- a/drivers/usb/host/xhci-plat.h
>> +++ b/drivers/usb/host/xhci-plat.h
>> @@ -14,7 +14,7 @@
>> #include "xhci.h" /* for hcd_to_xhci() */
>>
>> enum xhci_plat_type {
>> - XHCI_PLAT_TYPE_MARVELL_ARMADA,
>> + XHCI_PLAT_TYPE_MARVELL_ARMADA = 1,
>> XHCI_PLAT_TYPE_RENESAS_RCAR_GEN2,
>> XHCI_PLAT_TYPE_RENESAS_RCAR_GEN3,
>
> aren't these platforms using device tree ? Why aren't these just
> different compatible strings ?
According to 4efb2f69411456d35051e9047c15157c9a5ba217 "usb: host:
xhci-plat: add struct xhci_plat_priv" :
This patch adds struct xhci_plat_priv to simplify the code to match
platform specific variables. For now, this patch adds a member "type" in
the structure
Gregory
>
> --
> balbi
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2016-03-25 17:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 14:46 [PATCH] usb: host: xhci-plat: Make enum xhci_plat_type start at a non zero value Peter Griffin
2016-03-25 16:58 ` Felipe Balbi
2016-03-25 17:07 ` Gregory CLEMENT [this message]
2016-03-25 17:44 ` Felipe Balbi
2016-03-26 9:10 ` Peter Griffin
2016-03-26 10:10 ` Felipe Balbi
2016-03-29 9:04 ` Lee Jones
2016-03-28 6:55 ` Yoshihiro Shimoda
2016-03-28 8:30 ` Felipe Balbi
2016-03-28 10:01 ` Yoshihiro Shimoda
2016-04-11 15:44 ` Peter Griffin
2016-04-13 17:00 ` Mathias Nyman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvpmlc5e.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=maxime.coquelin@st.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
--cc=stable@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).