From: Felipe Balbi <balbi@kernel.org>
To: Minas Harutyunyan <Minas.Harutyunyan@synopsys.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>,
"stable\@vger.kernel.org" <stable@vger.kernel.org>,
Jack Mitchell <ml@embed.me.uk>
Subject: Re: [PATCH v2] usb: dwc2: Fix SET/CLEAR_FEATURE and GET_STATUS flows
Date: Wed, 15 Jan 2020 15:27:49 +0200 [thread overview]
Message-ID: <87o8v46e96.fsf@kernel.org> (raw)
In-Reply-To: <c2dd753e-d891-72f0-409e-5f23e5f170f0@synopsys.com>
[-- Attachment #1: Type: text/plain, Size: 861 bytes --]
Hi,
Minas Harutyunyan <Minas.Harutyunyan@synopsys.com> writes:
>> @@ -1768,16 +1771,17 @@ static int dwc2_hsotg_process_req_feature(struct dwc2_hsotg *hsotg,
>> return -EINVAL;
>>
>> hsotg->test_mode = wIndex >> 8;
>> - ret = dwc2_hsotg_send_reply(hsotg, ep0, NULL, 0);
>> - if (ret) {
>> - dev_err(hsotg->dev,
>> - "%s: failed to send reply\n", __func__);
>> - return ret;
>> - }
>> break;
>> default:
>> return -ENOENT;
>> }
>> +
>> + ret = dwc2_hsotg_send_reply(hsotg, ep0, NULL, 0);
>> + if (ret) {
>> + dev_err(hsotg->dev,
>> + "%s: failed to send reply\n", __func__);
>> + return ret;
>> + }
>> break;
>>
>> case USB_RECIP_ENDPOINT:
>>
>
> What about this patch?
See:
https://lore.kernel.org/linux-usb/875zhd6pw0.fsf@kernel.org/T/#u
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2020-01-15 13:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 17:14 [PATCH v2] usb: dwc2: Fix SET/CLEAR_FEATURE and GET_STATUS flows Minas Harutyunyan
2020-01-15 13:21 ` Minas Harutyunyan
2020-01-15 13:27 ` Felipe Balbi [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-01-21 10:17 Minas Harutyunyan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o8v46e96.fsf@kernel.org \
--to=balbi@kernel.org \
--cc=John.Youn@synopsys.com \
--cc=Minas.Harutyunyan@synopsys.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=ml@embed.me.uk \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).