From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga09.intel.com ([134.134.136.24]:56464 "EHLO mga09.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1727759AbeJ3WdT (ORCPT <rfc822;stable@vger.kernel.org>);
        Tue, 30 Oct 2018 18:33:19 -0400
From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Linux USB <linux-usb@vger.kernel.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        stable@vger.kernel.org
Subject: Re: [PATCH] usb: dwc3: core: Clean up ULPI device
In-Reply-To: <20181030131950.15422-1-felipe.balbi@linux.intel.com>
References: <20181030131950.15422-1-felipe.balbi@linux.intel.com>
Date: Tue, 30 Oct 2018 15:39:41 +0200
Message-ID: <87o9bbeeoy.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Felipe Balbi <felipe.balbi@linux.intel.com> writes:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> If dwc3_core_init_mode() fails with deferred probe,
> next probe fails on sysfs with
>
> sysfs: cannot create duplicate filename '/devices/pci0000:00/0000:00:11.0=
/dwc3.0.auto/dwc3.0.auto.ulpi'
>
> To avoid this failure, clean up ULPI device.
>
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> ---
>  drivers/usb/dwc3/core.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 88c80fcc39f5..fec97465ccac 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -1499,6 +1499,7 @@ static int dwc3_probe(struct platform_device *pdev)
>=20=20
>  err5:
>  	dwc3_event_buffers_cleanup(dwc);
> +	dwc3_ulpi_exit(dwc);
>=20=20
>  err4:
>  	dwc3_free_scratch_buffers(dwc);
> --=20
> 2.19.1
>
> ---------------------------------------------------------------------
> Intel Finland Oy
> Registered Address: PL 281, 00181 Helsinki=20
> Business Identity Code: 0357606 - 4=20
> Domiciled in Helsinki=20
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.

argh, apologies for this footer. Mail server had changes recently.

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlvYXx0ACgkQzL64meEa
mQZpSA//RsFBBX56T7RaXNSzEIh1ckCQ5sFJD+1+3otUMV0hYL8+JgrxvkCcB7Xo
juwUkrptBJzGoFwaC1U0LE5yXbqpwYGK+XsO50GX8WPzLyYGDzPKR1lyHmyCqQgx
CRBFGHRlbeShVvDSdzZ++GO8kgo6JawVHbc0Oy6zJ63ZyyqArnm8JdxDUAb/ijKB
mmsBB2mLHMIYmQVW1DxAwagcoAbgRhjb/5jmyUDb5Ra0fnwgEAZp6FpBGcMUeOSy
W1m33wz/xZVqkYuqlsbKmGHB4wtDm7FemrURtdv6bhoW7nstP0x2VZdrX4msBl6a
+75qswaZIrqMlMryZQtG1IJQ5vhqUyq5/o4jGhEyeIHitaAo+2MT/6/4mXQzzCHW
NGw4g2zAwN2fX07rj5mWhIgVLrXHVa6WMTSQJ6de0pjKoJxkF3iSbBrNkhTd7kit
DuJODVil2q+oGnENIkzKxxSRrANaFqdEHWG4EulHr2harNSMZNkdDZatx3r7Ef1n
j7F/G+bWN2weWvb0PJrZJU1C9mKJS4FycmYhuI3N0w4SF+ZdUQHDqII/YFsSIHYd
FcWykdOx5WsVOICIXkpsQ2shDud29XDBrP9Zq3Z+WbU1mCRhodhh65jm20xj5Hkp
yVRDFsLTiiZENKsNqjHSWmCHMIAWkc7zkZr1AElJw7RMcXU8xSg=
=kY3l
-----END PGP SIGNATURE-----
--=-=-=--