From: Jani Nikula <jani.nikula@intel.com>
To: "Pavel Machek" <pavel@ucw.cz>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: Imre Deak <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Ilya Tumaykin <itumaykin@gmail.com>,
Dirk Griesbach <spamthis@freenet.de>,
Mikko Rapeli <mikko.rapeli@iki.fi>,
Paul Bolle <pebolle@tiscali.nl>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/i915: apply the PCI_D0/D3 hibernation workaround everywhere on pre GEN6
Date: Wed, 01 Jul 2015 15:42:51 +0300 [thread overview]
Message-ID: <87oajwujzo.fsf@intel.com> (raw)
In-Reply-To: <20150701123524.GE7969@amd>
On Wed, 01 Jul 2015, Pavel Machek <pavel@ucw.cz> wrote:
> On Wed 2015-07-01 13:53:31, Ville Syrjälä wrote:
>> On Wed, Jul 01, 2015 at 11:51:27AM +0200, Pavel Machek wrote:
>> > > > > - Embedded panels have a well defined shutdown sequence. We
>> > don't
>> >
>> > > > > have
>> > > > > any good reason to not follow this, in fact for some panels the
>> > > > > subsequent reinitialization could be problematic in case of a hard
>> > > > > power-off. (Thanks to Jani for this info)
>> > > >
>> > > > Please cite concrete example. I have yet to see machine that would not
>> > > > power up on forced power down. In fact, I argue that such machine
>> > > > would be very broken, and that such machine does not exist. While we
>> > > > have these real machines broken:
>> > > >
>> > > > > + * Lenovo Thinkpad X301, X61s, X60, T60, X41
>> > > > > + * Fujitsu FSC S7110
>> > > > > + * Acer Aspire 1830T
>> > > >
>> > > > What makes you think that BIOS writers will do something different for
>> > > > Gen6+ hardware? X301 is not that old.
>> > >
>> > > Thinkpad X1 Carbon (IVB) is perfectly happy with the D3, so clearly
>> > > something changed for Lenovo at least. And most machines (old and new)
>> > > have no problems whatsoever with the D3.
>> >
>> > Well, one machine being happy does not matter that much...
>>
>> I said most machines, not one.
>>
>> > as going to
>> > D3 has no real benefits.
>>
>> Sure it does. Eventually we'll want to avoid resuming runtime suspended
>> devices when entering system suspend. For broken machines we'd need to
>> resume the GPU at that point.
>
> You want to optimize transition between suspend-to-RAM and
> hibernation? No? I thought so.
>
> So no benefits, 7 real, broken machines.
runtime suspended != suspend-to-RAM
> Pavel
>
> --
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
Jani Nikula, Intel Open Source Technology Center
next prev parent reply other threads:[~2015-07-01 12:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-30 14:06 [PATCH] drm/i915: apply the PCI_D0/D3 hibernation workaround everywhere on pre GEN6 Imre Deak
2015-06-30 17:27 ` Pavel Machek
2015-07-01 8:35 ` Jani Nikula
2015-07-01 8:45 ` Pavel Machek
2015-07-01 9:02 ` Ville Syrjälä
2015-07-01 9:51 ` Pavel Machek
2015-07-01 10:53 ` Ville Syrjälä
2015-07-01 12:35 ` Pavel Machek
2015-07-01 12:42 ` Jani Nikula [this message]
2015-07-01 12:57 ` [Intel-gfx] " David Weinehall
2015-07-15 6:22 ` Mikko Rapeli
2015-08-29 18:02 ` Mikko Rapeli
2015-08-31 15:45 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oajwujzo.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=itumaykin@gmail.com \
--cc=mikko.rapeli@iki.fi \
--cc=pavel@ucw.cz \
--cc=pebolle@tiscali.nl \
--cc=rjw@rjwysocki.net \
--cc=spamthis@freenet.de \
--cc=stable@vger.kernel.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).