From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com ([192.55.52.88]:17355 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752786AbbGAMkW convert rfc822-to-8bit (ORCPT ); Wed, 1 Jul 2015 08:40:22 -0400 From: Jani Nikula To: Pavel Machek , Ville =?utf-8?B?U3lyasOkbMOk?= Cc: Imre Deak , intel-gfx@lists.freedesktop.org, "Rafael J. Wysocki" , Ilya Tumaykin , Dirk Griesbach , Mikko Rapeli , Paul Bolle , Daniel Vetter , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915: apply the PCI_D0/D3 hibernation workaround everywhere on pre GEN6 In-Reply-To: <20150701123524.GE7969@amd> References: <1435673207-23030-1-git-send-email-imre.deak@intel.com> <20150630172706.GA28262@amd> <20150701090207.GR5176@intel.com> <20150701095127.GB7969@amd> <20150701105331.GS5176@intel.com> <20150701123524.GE7969@amd> Date: Wed, 01 Jul 2015 15:42:51 +0300 Message-ID: <87oajwujzo.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Wed, 01 Jul 2015, Pavel Machek wrote: > On Wed 2015-07-01 13:53:31, Ville Syrjälä wrote: >> On Wed, Jul 01, 2015 at 11:51:27AM +0200, Pavel Machek wrote: >> > > > > - Embedded panels have a well defined shutdown sequence. We >> > don't >> > >> > > > > have >> > > > > any good reason to not follow this, in fact for some panels the >> > > > > subsequent reinitialization could be problematic in case of a hard >> > > > > power-off. (Thanks to Jani for this info) >> > > > >> > > > Please cite concrete example. I have yet to see machine that would not >> > > > power up on forced power down. In fact, I argue that such machine >> > > > would be very broken, and that such machine does not exist. While we >> > > > have these real machines broken: >> > > > >> > > > > + * Lenovo Thinkpad X301, X61s, X60, T60, X41 >> > > > > + * Fujitsu FSC S7110 >> > > > > + * Acer Aspire 1830T >> > > > >> > > > What makes you think that BIOS writers will do something different for >> > > > Gen6+ hardware? X301 is not that old. >> > > >> > > Thinkpad X1 Carbon (IVB) is perfectly happy with the D3, so clearly >> > > something changed for Lenovo at least. And most machines (old and new) >> > > have no problems whatsoever with the D3. >> > >> > Well, one machine being happy does not matter that much... >> >> I said most machines, not one. >> >> > as going to >> > D3 has no real benefits. >> >> Sure it does. Eventually we'll want to avoid resuming runtime suspended >> devices when entering system suspend. For broken machines we'd need to >> resume the GPU at that point. > > You want to optimize transition between suspend-to-RAM and > hibernation? No? I thought so. > > So no benefits, 7 real, broken machines. runtime suspended != suspend-to-RAM > Pavel > > -- > (english) http://www.livejournal.com/~pavelmachek > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- Jani Nikula, Intel Open Source Technology Center