From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAEB3C4338F for ; Mon, 16 Aug 2021 12:28:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89E6163261 for ; Mon, 16 Aug 2021 12:28:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233796AbhHPM3B (ORCPT ); Mon, 16 Aug 2021 08:29:01 -0400 Received: from mga11.intel.com ([192.55.52.93]:31181 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235016AbhHPM3A (ORCPT ); Mon, 16 Aug 2021 08:29:00 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10077"; a="212730203" X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="212730203" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:28:29 -0700 X-IronPort-AV: E=Sophos;i="5.84,324,1620716400"; d="scan'208";a="519634845" Received: from ifridman-mobl.ger.corp.intel.com (HELO localhost) ([10.251.210.77]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2021 05:28:25 -0700 From: Jani Nikula To: "Sharma\, Swati2" , intel-gfx@lists.freedesktop.org Cc: Ankit Nautiyal , Uma Shankar , Ville Syrj_l_ , Imre Deak , Manasi Navare , Jos_ Roberto de Souza , Sean Paul , stable@vger.kernel.org Subject: Re: [PATCH] drm/i915/display: Drop redundant debug print In-Reply-To: <27387edf-5b67-e361-325e-0a9600a28da2@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20210812125845.27787-1-swati2.sharma@intel.com> <871r6xn5wd.fsf@intel.com> <04e2728f-a5e3-a8ee-9fdc-9affe753b59e@intel.com> <87wnolio9x.fsf@intel.com> <27387edf-5b67-e361-325e-0a9600a28da2@intel.com> Date: Mon, 16 Aug 2021 15:28:22 +0300 Message-ID: <87pmudinfd.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: > On 16-Aug-21 5:40 PM, Jani Nikula wrote: >> On Mon, 16 Aug 2021, "Sharma, Swati2" wrote: >>> On 13-Aug-21 1:16 PM, Jani Nikula wrote: >>>> On Thu, 12 Aug 2021, Swati Sharma wrote: >>>>> drm_dp_dpcd_read/write already has debug error message. >>>>> Drop redundant error messages which gives false >>>>> status even if correct value is read in drm_dp_dpcd_read(). >>>> >>>> I guess the only problem is it gets harder to associate the preceding >>>> low level error messages with intel_dp_check_link_service_irq(). *shrug* >>>> >>>> Reviewed-by: Jani Nikula >>>> >>>> >>> Thanks Jani for the review. Can you please merge? >> >> There was another version with open review? > > Yes. https://patchwork.freedesktop.org/series/93025/#rev3 > Should I add debug prints how Imre suggested in other IRQ func > to make it generic or should it be dropped from here too? > Quoting imre > "Yes, that's why I suggested to return for the '0 value read' case > without any message printed, but still keep the message for the case > when the drm_dp_dpcd_readb() fails." > "Ok, it's good to keep them in sync at least, so I'm ok with removing > the debug messages from here too." > > Please let me know what is the better approach. IMO just nuke them. BR, Jani >> >> BR, >> Jani. >> >> >>> >>>>> >>>>> Fixes: 9488a030ac91 ("drm/i915: Add support for enabling link status and recovery") >>>>> Cc: Swati Sharma >>>>> Cc: Ankit Nautiyal >>>>> Cc: Uma Shankar (v2) >>>>> Cc: Jani Nikula >>>>> Cc: "Ville Syrj_l_" >>>>> Cc: Imre Deak >>>>> Cc: Manasi Navare >>>>> Cc: Uma Shankar >>>>> Cc: "Jos_ Roberto de Souza" >>>>> Cc: Sean Paul >>>>> Cc: # v5.12+ >>>>> >>>>> Link: https://patchwork.freedesktop.org/patch/msgid/20201218103723.30844-12-ankit.k.nautiyal@intel.com >>>>> Signed-off-by: Swati Sharma >>>>> --- >>>>> drivers/gpu/drm/i915/display/intel_dp.c | 8 ++------ >>>>> 1 file changed, 2 insertions(+), 6 deletions(-) >>>>> >>>>> diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c >>>>> index c386ef8eb200..5c84f51ad41d 100644 >>>>> --- a/drivers/gpu/drm/i915/display/intel_dp.c >>>>> +++ b/drivers/gpu/drm/i915/display/intel_dp.c >>>>> @@ -3871,16 +3871,12 @@ static void intel_dp_check_link_service_irq(struct intel_dp *intel_dp) >>>>> return; >>>>> >>>>> if (drm_dp_dpcd_readb(&intel_dp->aux, >>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) { >>>>> - drm_dbg_kms(&i915->drm, "Error in reading link service irq vector\n"); >>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, &val) != 1 || !val) >>>>> return; >>>>> - } >>>>> >>>>> if (drm_dp_dpcd_writeb(&intel_dp->aux, >>>>> - DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) { >>>>> - drm_dbg_kms(&i915->drm, "Error in writing link service irq vector\n"); >>>>> + DP_LINK_SERVICE_IRQ_VECTOR_ESI0, val) != 1) >>>>> return; >>>>> - } >>>>> >>>>> if (val & HDMI_LINK_STATUS_CHANGED) >>>>> intel_dp_handle_hdmi_link_status_change(intel_dp); >>>> >> -- Jani Nikula, Intel Open Source Graphics Center