From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EF1BCD68ED for ; Tue, 10 Oct 2023 07:23:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442486AbjJJHXH (ORCPT ); Tue, 10 Oct 2023 03:23:07 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45856 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442492AbjJJHXE (ORCPT ); Tue, 10 Oct 2023 03:23:04 -0400 Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D684BC4; Tue, 10 Oct 2023 00:22:59 -0700 (PDT) Received: by mail.gandi.net (Postfix) with ESMTPSA id 124271BF206; Tue, 10 Oct 2023 07:22:55 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.94.2) (envelope-from ) id 1qq74r-00GHj6-Tn; Tue, 10 Oct 2023 09:22:49 +0200 From: Peter Korsgaard To: Greg KH Cc: Javier Carrasco , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] net: usb: dm9601: fix uninitialized variable use in dm9601_mdio_read References: <20231009-topic-dm9601_uninit_mdio_read-v2-1-f2fe39739b6c@gmail.com> <2023101036-fleshy-dude-aec0@gregkh> <87v8bfc83f.fsf@48ers.dk> <2023101018-venomous-uncured-47cf@gregkh> Date: Tue, 10 Oct 2023 09:22:49 +0200 In-Reply-To: <2023101018-venomous-uncured-47cf@gregkh> (Greg KH's message of "Tue, 10 Oct 2023 08:33:35 +0200") Message-ID: <87r0m3c56e.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: peter@korsgaard.com Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org >>>>> "Greg" == Greg KH writes: > On Tue, Oct 10, 2023 at 08:19:48AM +0200, Peter Korsgaard wrote: >> >>>>> "Greg" == Greg KH writes: >> >> > On Tue, Oct 10, 2023 at 12:26:14AM +0200, Javier Carrasco wrote: >> >> syzbot has found an uninit-value bug triggered by the dm9601 driver [1]. >> >> >> >> This error happens because the variable res is not updated if the call >> >> to dm_read_shared_word returns an error. In this particular case -EPROTO >> >> was returned and res stayed uninitialized. >> >> >> >> This can be avoided by checking the return value of dm_read_shared_word >> >> and propagating the error if the read operation failed. >> >> >> >> [1] https://syzkaller.appspot.com/bug?extid=1f53a30781af65d2c955 >> >> >> >> Signed-off-by: Javier Carrasco >> >> Reported-and-tested-by: syzbot+1f53a30781af65d2c955@syzkaller.appspotmail.com >> >> --- >> >> Changes in v2: >> >> - Remove unnecessary 'err == 0' case >> >> - Link to v1: https://lore.kernel.org/r/20231009-topic-dm9601_uninit_mdio_read-v1-1-d4d775e24e3b@gmail.com >> >> --- >> >> drivers/net/usb/dm9601.c | 7 ++++++- >> >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> > What commit id does this fix? >> >> It has been there since the beginning, so: >> >> Fixes: d0374f4f9c35cdfbee0 ("USB: Davicom DM9601 usbnet driver") >> >> Acked-by: Peter Korsgaard > Great, can someone add a cc: stable@ tag for this too please? Cc: stable@vger.kernel.org -- Bye, Peter Korsgaard