* Re: [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state
2024-08-29 6:18 ` [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state Seunghwan Baek
@ 2024-08-29 6:46 ` Ritesh Harjani
2024-09-02 10:27 ` Adrian Hunter
2024-09-03 12:37 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ritesh Harjani @ 2024-08-29 6:46 UTC (permalink / raw)
To: Seunghwan Baek, linux-kernel, linux-mmc, ulf.hansson,
quic_asutoshd, adrian.hunter
Cc: grant.jung, jt77.jang, junwoo80.lee, dh0421.hwang, jangsub.yi,
sh043.lee, cw9316.lee, sh8267.baek, wkon.kim, stable
Seunghwan Baek <sh8267.baek@samsung.com> writes:
> To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT
> bit. At this time, we need to check with &, not &&.
>
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
> Cc: stable@vger.kernel.org
> Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com>
Thanks for fixing it. Please feel free to add -
Reviewed-by: Ritesh Harjani <ritesh.list@gmail.com>
> ---
> drivers/mmc/host/cqhci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index c14d7251d0bb..a02da26a1efd 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -617,7 +617,7 @@ static int cqhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
> cqhci_writel(cq_host, 0, CQHCI_CTL);
> mmc->cqe_on = true;
> pr_debug("%s: cqhci: CQE on\n", mmc_hostname(mmc));
> - if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) {
> + if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT) {
> pr_err("%s: cqhci: CQE failed to exit halt state\n",
> mmc_hostname(mmc));
> }
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state
2024-08-29 6:18 ` [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state Seunghwan Baek
2024-08-29 6:46 ` Ritesh Harjani
@ 2024-09-02 10:27 ` Adrian Hunter
2024-09-03 12:37 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Adrian Hunter @ 2024-09-02 10:27 UTC (permalink / raw)
To: Seunghwan Baek, linux-kernel, linux-mmc, ulf.hansson, ritesh.list,
quic_asutoshd
Cc: grant.jung, jt77.jang, junwoo80.lee, dh0421.hwang, jangsub.yi,
sh043.lee, cw9316.lee, wkon.kim, stable
On 29/08/24 09:18, Seunghwan Baek wrote:
> To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT
> bit. At this time, we need to check with &, not &&.
>
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
> Cc: stable@vger.kernel.org
> Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/cqhci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index c14d7251d0bb..a02da26a1efd 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -617,7 +617,7 @@ static int cqhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
> cqhci_writel(cq_host, 0, CQHCI_CTL);
> mmc->cqe_on = true;
> pr_debug("%s: cqhci: CQE on\n", mmc_hostname(mmc));
> - if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) {
> + if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT) {
> pr_err("%s: cqhci: CQE failed to exit halt state\n",
> mmc_hostname(mmc));
> }
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state
2024-08-29 6:18 ` [PATCH v2 1/2] mmc: cqhci: Fix checking of CQHCI_HALT state Seunghwan Baek
2024-08-29 6:46 ` Ritesh Harjani
2024-09-02 10:27 ` Adrian Hunter
@ 2024-09-03 12:37 ` Ulf Hansson
2 siblings, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2024-09-03 12:37 UTC (permalink / raw)
To: Seunghwan Baek
Cc: linux-kernel, linux-mmc, ritesh.list, quic_asutoshd,
adrian.hunter, grant.jung, jt77.jang, junwoo80.lee, dh0421.hwang,
jangsub.yi, sh043.lee, cw9316.lee, wkon.kim, stable
On Thu, 29 Aug 2024 at 08:18, Seunghwan Baek <sh8267.baek@samsung.com> wrote:
>
> To check if mmc cqe is in halt state, need to check set/clear of CQHCI_HALT
> bit. At this time, we need to check with &, not &&.
>
> Fixes: a4080225f51d ("mmc: cqhci: support for command queue enabled host")
> Cc: stable@vger.kernel.org
> Signed-off-by: Seunghwan Baek <sh8267.baek@samsung.com>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/cqhci-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/cqhci-core.c b/drivers/mmc/host/cqhci-core.c
> index c14d7251d0bb..a02da26a1efd 100644
> --- a/drivers/mmc/host/cqhci-core.c
> +++ b/drivers/mmc/host/cqhci-core.c
> @@ -617,7 +617,7 @@ static int cqhci_request(struct mmc_host *mmc, struct mmc_request *mrq)
> cqhci_writel(cq_host, 0, CQHCI_CTL);
> mmc->cqe_on = true;
> pr_debug("%s: cqhci: CQE on\n", mmc_hostname(mmc));
> - if (cqhci_readl(cq_host, CQHCI_CTL) && CQHCI_HALT) {
> + if (cqhci_readl(cq_host, CQHCI_CTL) & CQHCI_HALT) {
> pr_err("%s: cqhci: CQE failed to exit halt state\n",
> mmc_hostname(mmc));
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread