From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: ebiederm@xmission.com (Eric W. Biederman) To: Willy Tarreau Cc: Luis Henriques , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Michal Tesar , "David S. Miller" , tyler.hicks@canonical.com References: <20140512003203.088027167@1wt.eu> <20140611184644.GA5442@hercules> <20140611194657.GU28551@1wt.eu> <87sinanv6u.fsf@canonical.com> <20140614175047.GH15102@1wt.eu> Date: Fri, 20 Jun 2014 15:16:07 -0700 In-Reply-To: <20140614175047.GH15102@1wt.eu> (Willy Tarreau's message of "Sat, 14 Jun 2014 19:50:47 +0200") Message-ID: <87simzgrbs.fsf@x220.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain Subject: Re: [ 059/143] sysctl net: Keep tcp_syn_retries inside the boundary Sender: linux-kernel-owner@vger.kernel.org List-ID: Willy Tarreau writes: > Hi Luis, > > On Thu, Jun 12, 2014 at 01:55:53PM +0100, Luis Henriques wrote: >> I was finally able to spend some more time with this and tried (a >> modified) Tyler's patch on top of 2.6.32.62, and it seems to work. >> Although I haven't done any extended testing, I don't see the two >> stack traces and the /proc/sys/net/ipv4/ directory seems to be >> correctly populated. >> >> I'm attaching the patch I've used, based on Tyler's. > > Would any of you or Tyler please kindly pass me a signed-off-by with > a commit message ? That would be great. Alternately I'd do it myself > and mention you authored them. If my memory serves it is possibe in 2.6.32 to set .ctl_name = CTL_UNNEEDED and not need to implement a .strategy routine at all. Given the fact that most people got the strategy routines slightly wrong and that sys_sysctl is effectively unused a strategy where you don't implement code that no-one will use in a backport I would be preferable. Since you have mentioned this has come up a couple of times if something else this will be something to think about for next time. I am puzzled why .ctl_name was populated in a backport at all. Eric