From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="13p/SZfi"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="9gL8jGZn"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="13p/SZfi"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="9gL8jGZn" Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB852F1; Sat, 9 Dec 2023 00:10:57 -0800 (PST) Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4EB3021DAA; Sat, 9 Dec 2023 08:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702109456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7c26mC+66VMAVt1GIwXQwVx/6dZRK5Hi5j94l+x99q0=; b=13p/SZfimif1weYWzGmk4lztLxOjIQlEvV+IRoJf84mrAuNmvA0kq0nNgMe1I7kDK+hbtr vlYAD/ZPQvuizUh6aISL7vEShjyVy6+QPv8WTRmH0y4cXuhFOyF7Gxe5ZfbpAYM2V8oKXR MxhQ/E1bpwnFCuY/j7nJD2iPtX5HeZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702109456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7c26mC+66VMAVt1GIwXQwVx/6dZRK5Hi5j94l+x99q0=; b=9gL8jGZnNgB0J8ZRNAGlJvX0Jp0orL8XvNXPIYD4vT1qImlMpynMhT4BEQZCwnji8+Y/tO mmjVqwdzTdEvRwAg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702109456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7c26mC+66VMAVt1GIwXQwVx/6dZRK5Hi5j94l+x99q0=; b=13p/SZfimif1weYWzGmk4lztLxOjIQlEvV+IRoJf84mrAuNmvA0kq0nNgMe1I7kDK+hbtr vlYAD/ZPQvuizUh6aISL7vEShjyVy6+QPv8WTRmH0y4cXuhFOyF7Gxe5ZfbpAYM2V8oKXR MxhQ/E1bpwnFCuY/j7nJD2iPtX5HeZY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702109456; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7c26mC+66VMAVt1GIwXQwVx/6dZRK5Hi5j94l+x99q0=; b=9gL8jGZnNgB0J8ZRNAGlJvX0Jp0orL8XvNXPIYD4vT1qImlMpynMhT4BEQZCwnji8+Y/tO mmjVqwdzTdEvRwAg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F0E98136D6; Sat, 9 Dec 2023 08:10:55 +0000 (UTC) Received: from dovecot-director2.suse.de ([10.150.64.162]) by imap1.dmz-prg2.suse.org with ESMTPSA id RI9QOQ8hdGWSdQAAD6G6ig (envelope-from ); Sat, 09 Dec 2023 08:10:55 +0000 Date: Sat, 09 Dec 2023 09:10:55 +0100 Message-ID: <87ttor6bjk.wl-tiwai@suse.de> From: Takashi Iwai To: Gergo Koteles Cc: Shenghao Ding , Kevin Lu , Baojun Xu , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, stable@vger.kernel.org Subject: Re: [PATCH v2] ALSA: hda/tas2781: leave hda_component in usable state In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 Precedence: bulk X-Mailing-List: stable@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spam-Score: -3.29 Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -3.29 X-Spamd-Result: default: False [-3.29 / 50.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.983]; RCPT_COUNT_SEVEN(0.00)[9]; MID_CONTAINS_FROM(1.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; BAYES_HAM(-2.99)[99.96%] X-Spam-Flag: NO On Fri, 08 Dec 2023 19:06:49 +0100, Gergo Koteles wrote: > > @@ -612,9 +612,13 @@ static void tas2781_hda_unbind(struct device *dev, > { > struct tasdevice_priv *tas_priv = dev_get_drvdata(dev); > struct hda_component *comps = master_data; > + comps = &comps[tas_priv->index]; > > - if (comps[tas_priv->index].dev == dev) > - memset(&comps[tas_priv->index], 0, sizeof(*comps)); > + if (comps->dev == dev) { > + comps->dev = NULL; > + strscpy(comps->name, "", sizeof(comps->name)); This looks suboptimal. Either just set *comp->name = 0, or fill all with memset(). thanks, Takashi