* [PATCH] io_uring: undeprecate epoll_ctl support
[not found] <64e5fbc2-b49f-5b7e-2a1e-aa1cef08e20c@kernel.dk>
@ 2023-05-06 9:55 ` Ben Noordhuis
2023-05-27 1:48 ` Sam James
2023-05-27 2:22 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Ben Noordhuis @ 2023-05-06 9:55 UTC (permalink / raw)
To: io-uring; +Cc: Ben Noordhuis, stable
Libuv recently started using it so there is at least one consumer now.
Cc: stable@vger.kernel.org
Fixes: 61a2732af4b0 ("io_uring: deprecate epoll_ctl support")
Link: https://github.com/libuv/libuv/pull/3979
Signed-off-by: Ben Noordhuis <info@bnoordhuis.nl>
---
io_uring/epoll.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/io_uring/epoll.c b/io_uring/epoll.c
index 9aa74d2c80bc..89bff2068a19 100644
--- a/io_uring/epoll.c
+++ b/io_uring/epoll.c
@@ -25,10 +25,6 @@ int io_epoll_ctl_prep(struct io_kiocb *req, const struct io_uring_sqe *sqe)
{
struct io_epoll *epoll = io_kiocb_to_cmd(req, struct io_epoll);
- pr_warn_once("%s: epoll_ctl support in io_uring is deprecated and will "
- "be removed in a future Linux kernel version.\n",
- current->comm);
-
if (sqe->buf_index || sqe->splice_fd_in)
return -EINVAL;
--
2.39.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: undeprecate epoll_ctl support
2023-05-06 9:55 ` [PATCH] io_uring: undeprecate epoll_ctl support Ben Noordhuis
@ 2023-05-27 1:48 ` Sam James
2023-05-27 2:22 ` Jens Axboe
2023-05-27 2:22 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Sam James @ 2023-05-27 1:48 UTC (permalink / raw)
To: info, Jens Axboe; +Cc: io-uring, stable, kernel
[-- Attachment #1: Type: text/plain, Size: 342 bytes --]
Hi,
New libuv is indeed in the wild now and CMake uses it, so I end up
getting
a tonne of:
```
[ 1763.697364] isc-net-0000: epoll_ctl support in io_uring is deprecated
and will be removed in a future Linux kernel version.
```
Could you confirm if this patch looks likely to land so we know if it's
OK
to backport it downstream?
Thank you!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 377 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: undeprecate epoll_ctl support
2023-05-27 1:48 ` Sam James
@ 2023-05-27 2:22 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-05-27 2:22 UTC (permalink / raw)
To: Sam James, info; +Cc: io-uring, stable, kernel
On 5/26/23 7:48 PM, Sam James wrote:
> Hi,
>
> New libuv is indeed in the wild now and CMake uses it, so I end up
> getting
> a tonne of:
> ```
> [ 1763.697364] isc-net-0000: epoll_ctl support in io_uring is deprecated
> and will be removed in a future Linux kernel version.
> ```
>
> Could you confirm if this patch looks likely to land so we know if it's
> OK
> to backport it downstream?
Yeah, I think this is the best plan. I was out of town for a bit
around when it got reposted and hence missed it, I'll queue it
up for this release.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] io_uring: undeprecate epoll_ctl support
2023-05-06 9:55 ` [PATCH] io_uring: undeprecate epoll_ctl support Ben Noordhuis
2023-05-27 1:48 ` Sam James
@ 2023-05-27 2:22 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2023-05-27 2:22 UTC (permalink / raw)
To: io-uring, Ben Noordhuis; +Cc: stable
On Sat, 06 May 2023 11:55:02 +0200, Ben Noordhuis wrote:
> Libuv recently started using it so there is at least one consumer now.
>
>
Applied, thanks!
[1/1] io_uring: undeprecate epoll_ctl support
commit: 4ea0bf4b98d66a7a790abb285539f395596bae92
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-05-27 2:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <64e5fbc2-b49f-5b7e-2a1e-aa1cef08e20c@kernel.dk>
2023-05-06 9:55 ` [PATCH] io_uring: undeprecate epoll_ctl support Ben Noordhuis
2023-05-27 1:48 ` Sam James
2023-05-27 2:22 ` Jens Axboe
2023-05-27 2:22 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox