From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com ([192.55.52.115]:58737 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754359AbbLWLIB convert rfc822-to-8bit (ORCPT ); Wed, 23 Dec 2015 06:08:01 -0500 From: Jani Nikula To: Daniel Vetter , Takashi Iwai Cc: Ville =?utf-8?B?U3lyasOkbMOk?= , Chris Wilson , intel-gfx@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org, "Goel\, Akash" Subject: Re: [Intel-gfx] [PATCH v5] drm/i915: Pin the ifbdev for the info->system_base GGTT mmapping In-Reply-To: <20151217155953.GA30437@phenom.ffwll.local> References: <20151124212049.GA26526@wunner.de> <1449245126-26158-1-git-send-email-chris@chris-wilson.co.uk> <20151210163604.GC4437@intel.com> <20151217155953.GA30437@phenom.ffwll.local> Date: Wed, 23 Dec 2015 13:07:37 +0200 Message-ID: <87twn95sp2.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: stable-owner@vger.kernel.org List-ID: On Thu, 17 Dec 2015, Daniel Vetter wrote: > On Thu, Dec 10, 2015 at 05:41:30PM +0100, Takashi Iwai wrote: >> On Thu, 10 Dec 2015 17:36:04 +0100, >> Ville Syrjälä wrote: >> > >> > On Fri, Dec 04, 2015 at 04:05:26PM +0000, Chris Wilson wrote: >> > > A long time ago (before 3.14) we relied on a permanent pinning of the >> > > ifbdev to lock the fb in place inside the GGTT. However, the >> > > introduction of stealing the BIOS framebuffer and reusing its address in >> > > the GGTT for the fbdev has muddied waters and we use an inherited fb. >> > > However, the inherited fb is only pinned whilst it is active and we no >> > > longer have an explicit pin for the info->system_base mmapping used by >> > > the fbdev. The result is that after some aperture pressure the fbdev may >> > > be evicted, but we continue to write the fbcon into the same GGTT >> > > address - overwriting anything else that may be put into that offset. >> > > The effect is most pronounced across suspend/resume as >> > > intel_fbdev_set_suspend() does a full clear over the whole scanout. >> > > >> > > v2: Only unpin the intel_fb is we allocate it. If we inherit the fb from >> > > the BIOS, we do not own the pinned vma (except for the reference we add >> > > in this patch for our access via info->screen_base). >> > > >> > > v3: Finish balancing the vma pinning for the normal !preallocated case. >> > > >> > > v4: Try to simplify the pinning even further. >> > > v5: Leak the VMA (cleaned up by object-free) to avoid complicated error paths. >> > > >> > > Signed-off-by: Chris Wilson >> > > Cc: "Goel, Akash" >> > > Cc: Daniel Vetter >> > > Cc: Jesse Barnes >> > > Cc: Lukas Wunner >> > > Cc: stable@vger.kernel.org >> > >> > This seems to have fixed my garbled text+fbcon dead after >> > suspend/hibernate issues. Well, only had the patch in for a day or so, >> > but so far so good. >> > >> > Tested-by: Ville Syrjälä >> > >> > Takashi, don't know if you already found this patch, but it's definitely >> > something you should try as well. >> >> Great, I'll give this a try. Thanks! > > Pulled both patches into dinq. Jani, can you please cherry-pick? Picked the first, but I don't have the time to fix the conflicts on the second one. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center