From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from arroyo.ext.ti.com ([192.94.94.40]:42698 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753198AbbJMSQY (ORCPT ); Tue, 13 Oct 2015 14:16:24 -0400 From: Felipe Balbi To: Krzysztof Opasiak CC: , , , Subject: Re: [PATCH v3 2/2] usb: gadget: loopback: Fix looping back logic implementation In-Reply-To: <561D4954.5060905@samsung.com> References: <1442947223-13277-1-git-send-email-k.opasiak@samsung.com> <1442947223-13277-2-git-send-email-k.opasiak@samsung.com> <20150930161152.GG32625@saruman.tx.rr.com> <20150930161519.GH32625@saruman.tx.rr.com> <561D4954.5060905@samsung.com> Date: Tue, 13 Oct 2015 13:16:16 -0500 Message-ID: <87twpud47j.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi, Krzysztof Opasiak writes: > Hi, > > On 09/30/2015 06:15 PM, Felipe Balbi wrote: >> On Wed, Sep 30, 2015 at 11:11:52AM -0500, Felipe Balbi wrote: >>> On Tue, Sep 22, 2015 at 08:40:23PM +0200, Krzysztof Opasiak wrote: >>>> Since: >>>> >>>> commit e0857ce58e8658657f5f12fe25272b93cfeb16aa >>> >>> this should be something like: >>> >>> Since commit e0857ce58e86 (" .... ") >>> >>>> ("usb: gadget: loopback: don't queue requests to bogus endpoints") >>>> >>>> Loopback function is not realy working as that commit removed >>>> all looping back logic. After that commit ep-out works like >>>> /dev/null and ep-in works like /dev/zero. >>>> >>>> This commit fix this issue by allocating set of out requests >>>> and set of in requests but each out req shares buffer with >>>> one in req: >>>> >>>> out_req->buf ---> buf <--- in_req.buf >>>> out_req->context <---> in_req.context >>>> >>>> The completion routine simply enqueue the suitable req in >>>> an oposite direction. >>>> >>>> Cc: # 3.18+ >>> >>> missing Fixes: e0857ce58e86 ("...") >>> >>> I'll fix both while applying, but make sure to make this proper >>> next time. >> >> actually fails to apply to v4.3-rc3, please rebase. >> > > Sorry for my late response but I was out of office due to ELCE in Dublin. > > I managed to apply this series onto 4.3-rc5 without any conflicts. > > Would you like me to split this series into 2 separate one so you can=20 > apply only this commit and leave the first one for the next merge window? yes, please. Thanks =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWHUpxAAoJEIaOsuA1yqREiFwQAJgW7RH2fSjg+PAskIxmRpTc GjJvlfRC0LPe2SY5oU9YEe0rngZG3Titkm+9MfIroDXW4OReVIRP76RMcEhaiPEa ZkQOtEGki2oO7DbAB8UhwGXoehiiZnWdBtcyaHwZJF3Z4mp2MQvfnA7NSm7QdaUI WpNxKn7Kb5PoX8lNt4qklDex9dQJhCmrCSiJCMMAhf91mgTMpzG5HxNWpU1zRxsY hFiv50d1g7dduDIHB/4noge59DYhXViTyx7xs2J/6nhGVDGnDpzVywTwuUZewDyf csEyiMwyOToVcPdCuVbgPfAgwkToa162cq+S0N3ithRmLowkZjXZdv+6YI3y4+Oo dEV5jdLs2cImUJeUTWG6NmJi8BlN26fGZJCjGYKhKd4VeeMNqGkkzEVhbT8Ro4Ie 98ZB8v2rXHwT9J512VHbK/6QAZMpC47yDIJv09/MCX1pAqryxECIVoWk3xdzxoBK It7vYLaY3Nt8x2G5hPpct1fHAIDE3CEa+Lu/N3ups9uM/d87Ua/iWmBvFfXIu7Qx HXaGE1y9OYX+XzjklHwbKaYwYAZL4K2RGlQLnj8AFForsXbuI3YvEkD+9KKlp2o9 NZY8G17Cs11hizk9UmreXYyJv9eDv50l+nXsZ1+FMQTSj2PZMd5Tf9gZsb0Gl1hC XZQCFq+yP718NZdTGtBI =7HWn -----END PGP SIGNATURE----- --=-=-=--