From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from comal.ext.ti.com ([198.47.26.152]:48410 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751219AbbJLShu (ORCPT ); Mon, 12 Oct 2015 14:37:50 -0400 From: Felipe Balbi To: Masakazu Mokuno CC: , Greg Kroah-Hartman , , Subject: Re: [PATCH] Revert "usb: dwc3: gadget: drop unnecessary loop when cleaning up TRBs" In-Reply-To: <20150902122916.GC7809@saruman.tx.rr.com> References: <1441039708-2504-1-git-send-email-ville.syrjala@linux.intel.com> <20150831165413.GF31101@saruman.tx.rr.com> <20150902170934.C0BB.B02B0EB8@hq.scei.sony.co.jp> <20150902122916.GC7809@saruman.tx.rr.com> Date: Mon, 12 Oct 2015 13:37:40 -0500 Message-ID: <87twpwq6ff.fsf@saruman.tx.rr.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Felipe Balbi writes: > On Wed, Sep 02, 2015 at 05:09:39PM +0900, Masakazu Mokuno wrote: >> Hi, >>=20 >> On Mon, 31 Aug 2015 11:54:13 -0500 >> Felipe Balbi wrote: >>=20 >> > On Mon, Aug 31, 2015 at 07:48:28PM +0300, ville.syrjala@linux.intel.co= m wrote: >> > > From: Ville Syrj=E8=88=81=E3=83=BB >> > >=20 >> > > This reverts commit 8f2c9544aba636134303105ecb164190a39dece4. >> > >=20 >> > > As it breaks g_ether on my Baytrail FFRD8 device. Everything starts = out >> > > fine, but after a bit of data has been transferred it just stops >> > > flowing. >> > >=20 >> > > Note that I do get a bunch of these "NOHZ: local_softirq_pending 08" >> > > when booting the machine, but I'm not really sure if they're related >> > > to this problem. >> >=20 >> > I have a feeling your problem is elsewhere. We *are* completing one TRB >> > at a time.=20 >>=20 >> If usb_request.no_interrupt is flagged, it seems dwc3 does not set IOC >> on the corresponding TRB. Does it break the assumption every TRB >> (without SG) will trigger one corresponding EP event? >> u_ether is the function module that utilizes 'no_interrupt' flag. > > XferInProgress should still trigger. Besides, I tested with the exact > same setup (different SoC though), just look at the thread. I found a way to reproduce this on my end. What I was missing was the use of request.no_interrupt. We won't get XferInProgress for all TRBs if IOC isn't set in all of them. I'll apply this patch ASAP as it fixes the problem I managed to reproduce (ping -s 40000 makes it fail here) =2D-=20 balbi --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJWG/31AAoJEIaOsuA1yqRE/DkP/11jIgOZvAl6Mr9WaLiwkg44 6vJI8QaSMrZJmI6qiDyK6MmqzANSNDf0Xp7OPTmfByukiE6syQcQnPmV/BDk1ilR ES5UNy+6MlY/WngpdADVhMMphV9stZW0pLr3D7ivEK+9DXrcbYin08WurXNffCm9 F0zgo7mibHTxDPWg2n32EOvCPTkNs7qvNSxU0mMYK4RTpxvdtS5tqBm/5dyaGZJZ WTWe01mXvERLnAKcEmSfm4/VMF0WQD403qg59Tan3Zr21UDVF89dDTl05KQRkIAU UDfmGdz7d18rv0qj6/xYvWTLwgjHoOOaC9Y/zp0QwqnB4SDeL5d6JbcrW+Ck1bpb TG2XFyvy2DWQbBwVPCinHoUSjAJH4HlqEM2AOjVHtBIE2dGbcjiCj2ZEmFj+tQto BccLp44XO/6V+a0JyHuZhONz8unsb4dCILlPd9PHqGtJdmUVt8IiRtQ41L5PnwJa rthl1Z9En9u3AiHplBNtzwEMi60saWGAcCIeysTw71oXIloZ+rxzTYooZDJGB4yC gBje52Gr6+jvca/fIdOAqdGLz9KMe8xnJNP9UL4VZGuk2diLTg6hD6cUZKTubXXg JON6A6mvqgH2nmwGMN4LLr1SeDSdm4O+uOjUQA7vOUJnFJLa/HM19KjOpcRLzl6c 7B0F3aSFynOUNaJOESNg =gQhl -----END PGP SIGNATURE----- --=-=-=--