From: Rusty Russell <rusty@rustcorp.com.au>
To: Amit Shah <amit.shah@redhat.com>,
Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@hitachi.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
stable@vger.kernel.org,
virtualization@lists.linux-foundation.org,
Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>,
yrl.pp-manager.tt@hitachi.com,
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write
Date: Tue, 23 Jul 2013 11:21:09 +0930 [thread overview]
Message-ID: <87txjm9h82.fsf@rustcorp.com.au> (raw)
In-Reply-To: <20130722063341.GA1806@amit-x200.redhat.com>
Amit Shah <amit.shah@redhat.com> writes:
> On (Mon) 22 Jul 2013 [13:00:43], Yoshihiro YUNOMAE wrote:
>> Hi,
>>
>> This patch set fixes two bugs of splice_write in the virtio-console driver.
>>
>> [BUG1] Although pipe->nrbufs is empty, the driver tries to do splice_write.
>> => This induces oops in sg_init_table().
>>
>> [BUG2] No lock for competition of splice_write.
>> => This induces oops in splice_from_pipe_feed() by bug of any user
>> application.
>>
>> These reports are written in each patch.
>>
>> Changes in V2:
>> - Fix a locking problem for error
>>
>> Changes in V3:
>> - Add Reviewed-by lines and stable@ line in sign-off area
>
> Thank you!
>
> Rusty, please pick this up.
Both applied, thankyou.
Cheers,
Rusty.
prev parent reply other threads:[~2013-07-23 1:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 4:00 [PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write Yoshihiro YUNOMAE
2013-07-22 4:00 ` [PATCH V3 1/2] [BUGFIX] virtio/console: Quit from splice_write if pipe->nrbufs is 0 Yoshihiro YUNOMAE
2013-07-22 4:00 ` [PATCH V3 2/2] [BUGFIX] virtio/console: Add pipe_lock/unlock for splice_write Yoshihiro YUNOMAE
2013-07-22 6:33 ` [PATCH V3 0/2] [BUGFIX] virtio/console: Fix two bugs of splice_write Amit Shah
2013-07-23 1:51 ` Rusty Russell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txjm9h82.fsf@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=amit.shah@redhat.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hidehiro.kawai.ez@hitachi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=stable@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
--cc=yoshihiro.yunomae.ez@hitachi.com \
--cc=yrl.pp-manager.tt@hitachi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).