From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from anholt.net ([50.246.234.109]:39296 "EHLO anholt.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751463AbeEGP4R (ORCPT ); Mon, 7 May 2018 11:56:17 -0400 From: Eric Anholt To: Boris Brezillon , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Cc: Boris Brezillon , stable@vger.kernel.org Subject: Re: [PATCH] drm/vc4: Fix scaling of uni-planar formats In-Reply-To: <20180507121303.5610-1-boris.brezillon@bootlin.com> References: <20180507121303.5610-1-boris.brezillon@bootlin.com> Date: Mon, 07 May 2018 08:56:14 -0700 Message-ID: <87vabz1mu9.fsf@anholt.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Sender: stable-owner@vger.kernel.org List-ID: --=-=-= Content-Type: text/plain Boris Brezillon writes: > When using uni-planar formats (like RGB), the scaling parameters are > stored in plane 0, not plane 1. > > Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.") > Cc: stable@vger.kernel.org > Signed-off-by: Boris Brezillon Reviewed-by: Eric Anholt Looking at the other branch, did I get the scl0/scl1 backwards? HVS docs say for non-444 YCBCR: "In these cases Channel 0 performs Y/Alpha scaling and Channel 1 performs CB/CR scaling and should be configured as appropriate." --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlrwdx4ACgkQtdYpNtH8 nujAUQ//XtTJ4QfgMSYLM1n0mH6iPbdv+VpYkKALDT+UbhAyEyOkV8YGDYLH1HtI rCJBQxELLp0mXJTzGZTwcoGrRXneyyydOA2OawDr46BXVUJAaeurKwS7jOLHGyDU xOUdIKMzq5224NF2G2mQqW3BjTqflocEkEr/LoCdAywwcTunwuSSXlbhMCkG6QYg l/arFCk43xDUV/D3gRBAdW3YFZHO7y8Vp7LoUHN0DX1/IkU0FGIKwwhXhKTkPc4N DDLRvJ3UaYPvS0kOziaHJ0ZZ3Sudq/RoLnddWfCENirB9ib32oa557hrmBf/xaZe mKvdVM8n+EizH22lusDXaYCDSiSwISnOOGBHcwFwwDDe8vDpI0o8VFuYNjMNhmcf QBD1sl2MJaM+uKfp/V0G3SKV0Zy53Ba5/3Zp5CDUVdYKRR+ftSHrF/dzFlSQqQcW THi+KL/F6IkTkROejTgm+cmXOthU1C7bW6khqF+4aM9FCsK4sx2IGh9KH8qFRGNu PfSniNHPq0C99NyLTanK8KrVOFoQViHzrCJpuDzS8KuAMBYgun067XlUJ5kJkT8y cfE+XEWfOHLUA4nnjFJEctgAY/Ecvs7rqsB0lE+DSUDYBB7puKa4+mzz8soI5jZ6 nqbT3rCX17GmLNVJCPXFXdzVIhEnKawbwjV2zmq/wJJuLNmbOi4= =cAU2 -----END PGP SIGNATURE----- --=-=-=--