From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mga06.intel.com ([134.134.136.31]:64590 "EHLO mga06.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1754280AbeALI0O (ORCPT <rfc822;stable@vger.kernel.org>);
        Fri, 12 Jan 2018 03:26:14 -0500
From: Felipe Balbi <balbi@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
        "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>
Cc: John Youn <John.Youn@synopsys.com>,
        "stable\@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] usb: dwc3: gadget: Set maxpacket size for ep0 IN
In-Reply-To: <30102591E157244384E984126FC3CB4F300CD85D@us01wembx1.internal.synopsys.com>
References: <cover.1515618112.git.thinhn@synopsys.com> <c4a0e8b7be2035eadf54fbf27dfb79f9efb852a7.1515618112.git.thinhn@synopsys.com> <87o9m0yfne.fsf@linux.intel.com> <30102591E157244384E984126FC3CB4F300CD85D@us01wembx1.internal.synopsys.com>
Date: Fri, 12 Jan 2018 10:25:53 +0200
Message-ID: <87vag7wkj2.fsf@linux.intel.com>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
> Hi,
>
> On 1/11/2018 12:16 AM, Felipe Balbi wrote:
>>=20
>> Hi,
>>=20
>> Thinh Nguyen <Thinh.Nguyen@synopsys.com> writes:
>>> There are 2 control endpoint structures for DWC3. However, the driver
>>> only updates the OUT direction control endpoint structure during
>>> ConnectDone event. DWC3 driver needs to update the endpoint max packet
>>> size for control IN endpoint as well. If the max packet size is not
>>> properly set, then the driver will incorrectly calculate the data
>>> transfer size and fail to send ZLP for HS/FS 3-stage control read
>>> transfer.
>>>
>>> The fix is simply to update the max packet size for the ep0 IN direction
>>> during ConnectDone event.
>>>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
>>=20
>> missing Fixes tag
>
> This bug has been there since the beginning. There's no particular=20
> commit that it fixes.

yes there is; the very first one ;-)

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEElLzh7wn96CXwjh2IzL64meEamQYFAlpYcRMACgkQzL64meEa
mQYAWhAAqkTQGMFjPpaYDITaWPmEGT4Bd85Ej94ohEvzUwmHM0YTVRxVmGr2knAp
GAEzdqUTy25AuWQLjOoXHTz3r98UnffoJu7GkqoSEQpTQaqjTVgo5Mqf6v3FzK25
hLs45nsYDG596qQ1EKGWBjR17hY/D0w/j+2q6yGve4cEFmQuG9bBFBTknTRiyGNR
Rtt5yPE+/muDebTw+q7v4FIhRmhxCVK/yTNoU4Rg+quLj/1aiyBfolee8zD40Ye9
chfT2iDUIsLyVmZEdEsisWqEDM/vI8YiIZR/nsUxvbOdbh2vXYbVN2siv2bZNUhU
VkguDitxbAeottz8JvTWWfDFtX9CRik1YlR3Gc4f4AsIy5oTPo3rcdNdIjR96bas
C3JzA8Nka7i4fW/upRbYZXlsiVtBccnxZ2irlxTdfakeyD7Ud1DbRix+st6birQd
EJKpHYbFeVVguYEc0bvml5Qr/DyJkcCVRP1A/NwZBXk/g0ocSRBrl6dKZLn21JKQ
OEFIaMvKTJRGaBuDcU61zYKvA0x+F19QXIiy0S6GEPgw6iKqvx2HzZ20G8DQlpSg
JERd097Frpsom1ZEqC2Rma8UXNbON+QmZowXcr0SqpFimJ3nr37LpmHn0LwijYRc
A9t8c6I9je8k+DMOAt4MZ13s1y7gMSkvOJaM2Et1DKKz1pH/6H0=
=sh3A
-----END PGP SIGNATURE-----
--=-=-=--