stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org,
	weiyongjun1@huawei.com
Subject: Re: FAILED: patch "[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359" failed to apply to 4.9-stable tree
Date: Mon, 09 Jan 2017 20:30:42 +0200	[thread overview]
Message-ID: <87vatot7al.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <29741a09-dd16-6fd5-3749-fd57db73f2ff@lwfinger.net> (Larry Finger's message of "Mon, 9 Jan 2017 11:19:45 -0600")

Larry Finger <Larry.Finger@lwfinger.net> writes:

> On 01/09/2017 08:40 AM, Kalle Valo wrote:
>> <gregkh@linuxfoundation.org> writes:
>>
>>> The patch below does not apply to the 4.9-stable tree.
>>> If someone wants it applied there, or to any other stable or longterm
>>> tree, then please email the backport, including the original git commit
>>> id to <stable@vger.kernel.org>.
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>> ------------------ original commit in Linus's tree ------------------
>>>
>>> From 22b68b93ae2506bd56ee3bf232a51bc8ab955b56 Mon Sep 17 00:00:00 2001
>>> From: Larry Finger <Larry.Finger@lwfinger.net>
>>> Date: Mon, 19 Dec 2016 20:38:12 -0600
>>> Subject: [PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359
>>>
>>> With commit e49656147359 {"rtlwifi: Use dev_kfree_skb_irq instead of
>>> kfree_skb"), the method used to free an skb was changed because the
>>> kfree_skb() was inside a spinlock. What was forgotten is that kfree_skb()
>>> guards against a NULL value for the argument. Routine dev_kfree_skb_irq()
>>> does not, and a test is needed to prevent kernel panics.
>>>
>>> Fixes: e49656147359 ("rtlwifi: Use dev_kfree_skb_irq instead of kfree_skb")
>>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>>> Cc: Stable <stable@vger.kernel.org> # 4.9+
>>> Cc: Wei Yongjun <weiyongjun1@huawei.com>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>
>> Larry, are you planning to port this to 4.9?
>
> No. Apparently I got confused again and my use of the Cc to stable was
> incorrect. Commit 49656147359 was not applied until the 4.10 merge.
> The source of the confusion is related to when the various commits
> appear in the git log for mainline. The code, however, has the final
> word. :)

Ah, ok. I'm actually having similar problems and planning to come up
with a some sort of web page which would show what was the first Linux
release to contain the commit. (git-describe doesn't tell that and AFAIK
there is no other git command to show it.) If only I had more free time :)

-- 
Kalle Valo

  reply	other threads:[~2017-01-09 18:30 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 12:20 FAILED: patch "[PATCH] rtlwifi: Fix kernel oops introduced with commit e49656147359" failed to apply to 4.9-stable tree gregkh
2017-01-09 14:40 ` Kalle Valo
2017-01-09 17:19   ` Larry Finger
2017-01-09 18:30     ` Kalle Valo [this message]
2017-01-09 20:04       ` Greg KH
2017-01-09 20:39         ` Kalle Valo
2017-01-09 22:40         ` Larry Finger
2017-01-10  5:35           ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vatot7al.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=Larry.Finger@lwfinger.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=stable@vger.kernel.org \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).