From: Felipe Balbi <felipe.balbi@linux.intel.com>
To: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"mathias.nyman\@intel.com" <mathias.nyman@intel.com>,
"gregkh\@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb\@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-renesas-soc\@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"stable\@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset()
Date: Fri, 22 Apr 2016 10:08:47 +0300 [thread overview]
Message-ID: <87vb3a86io.fsf@intel.com> (raw)
In-Reply-To: <SG2PR06MB0919C955B867DCF6B7B869EAD86F0@SG2PR06MB0919.apcprd06.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 1498 bytes --]
Hi,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> writes:
>> > > And, kernel log is the following:
>> > >
>> > > [ 1.565605] xhci-hcd ee000000.usb: xHCI Host Controller
>> > > [ 1.570636] xhci-hcd ee000000.usb: new USB bus registered, assigned bus number 5
>> > > [ 22.270160] xhci-hcd ee000000.usb: can't setup: -110
>> > > [ 22.274931] xhci-hcd ee000000.usb: USB bus 5 deregistered
>> > > [ 22.280158] xhci-hcd: probe of ee000000.usb failed with error -110
>> > >
>> > > The timestamp is strange to me. But, logs of R-Car H3 (ES1.0) and
>> > > R-Car H2 were the same.
>> >
>> > yeah, seems like your system timer is counting twice for each tick.
>>
>> Yes, I will investigate this later.
>>
>> > > Should I revise the commit log in detail?
>> >
>> > Sure, but let's first why this is the case. It's unclear, to me at
>> > least, why reset fails.
>>
>> I understood it. I will investigate why reset fails first.
>
> According to the HW team of R-Car SoCs, the firmware of R-Car USB 3.0 host controller
> will control the reset. So, if the xhci-rcar driver doesn't do firmware downloading,
> the reset of USB3.0 host controller doesn't work correctly.
> The HW team intends to describe this specification on next datasheet revision.
> (In other words, the current datasheet doesn't mention exactly about this.)
that explains it, thanks :-)
> So, I will revise the commit log and submit such a patch later.
great, thanks
--
balbi
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
prev parent reply other threads:[~2016-04-22 7:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 9:49 [PATCH] usb: host: xhci-rcar: Avoid long wait in xhci_reset() Yoshihiro Shimoda
2016-04-21 10:04 ` Felipe Balbi
2016-04-21 10:14 ` Yoshihiro Shimoda
2016-04-21 10:19 ` Felipe Balbi
2016-04-21 10:27 ` Yoshihiro Shimoda
2016-04-21 12:57 ` Geert Uytterhoeven
2016-04-21 13:59 ` Felipe Balbi
2016-04-25 14:57 ` Geert Uytterhoeven
2016-04-26 10:13 ` Yoshihiro Shimoda
2016-04-22 6:26 ` Yoshihiro Shimoda
2016-04-22 7:08 ` Felipe Balbi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87vb3a86io.fsf@intel.com \
--to=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=stable@vger.kernel.org \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).