stable.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nick Alcock <nick.alcock@esperi.org.uk>
To: Bernd Schubert <bernd.schubert@fastmail.fm>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-scsi@vger.kernel.org, nick.cheng@areca.com.tw,
	stable@vger.kernel.org, Douglas Gilbert <dgilbert@interlog.com>,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Subject: Re: [PATCH] scsi disk: Use its own buffer for the vpd request
Date: Sat, 03 Aug 2013 12:17:31 +0100	[thread overview]
Message-ID: <87vc3nuipg.fsf@spindle.srvr.nix> (raw)
In-Reply-To: <51FA71E2.6010501@fastmail.fm> (Bernd Schubert's message of "Thu, 01 Aug 2013 16:34:10 +0200")

On 1 Aug 2013, Bernd Schubert stated:

> Once I noticed that scsi_get_vpd_page() works fine from other function
> calls and that it is not 0x89, but already 0x0 that fails fixing it became
> easy.
>
> Nix, any chance you could verify it also works for you?

Confirmed, thank you!

> Somehow older areca firmware versions have issues with
> scsi_get_vpd_page() and a large buffer.

I wonder if they're using math modulo SD_BUF_SIZE-1 by mistake, so they
misinterpret this as zero? (Still, doing math modulo 511 seems very
odd, even if this firmware *does* only support 512-byte sectors.)

-- 
NULL && (void)

  parent reply	other threads:[~2013-08-03 11:17 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87r4ehfzhf.fsf@spindle.srvr.nix>
     [not found] ` <51F667C2.4020801@fastmail.fm>
     [not found]   ` <87mwp5frdl.fsf@spindle.srvr.nix>
     [not found]     ` <51F67959.2060803@fastmail.fm>
2013-07-29 21:09       ` [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition Nix
2013-07-29 23:34         ` Martin K. Petersen
2013-07-30 18:09           ` Bernd Schubert
2013-07-31  0:07             ` Nick Alcock
2013-07-31  3:19               ` Martin K. Petersen
2013-07-31  3:15             ` Martin K. Petersen
2013-07-31 17:51               ` Bernd Schubert
2013-07-31 18:40                 ` Bernd Schubert
2013-08-01 14:34                   ` [PATCH] scsi disk: Use its own buffer for the vpd request Bernd Schubert
2013-08-01 14:37                     ` Bernd Schubert
2013-08-02  3:00                     ` Martin K. Petersen
2013-08-26 20:15                       ` Bernd Schubert
2013-08-02 23:46                     ` Nick Alcock
2013-08-03 11:17                     ` Nick Alcock [this message]
2013-08-30 10:01                     ` Nix
2013-08-31  1:53                       ` Greg KH
2013-08-31 19:48                         ` Nix
2013-09-01 18:40                           ` Bernd Schubert
2013-09-20 22:51                             ` Martin K. Petersen
2013-07-30  0:28         ` [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition Douglas Gilbert
2013-07-30  0:56           ` Nix
2013-07-30 18:14             ` Bernd Schubert
2013-07-30 21:20               ` Nix
2013-08-01 14:55                 ` Bernd Schubert
2013-08-01 16:04                   ` Nix
2013-08-01 16:21                     ` Bernd Schubert
2013-07-31  3:10           ` Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87vc3nuipg.fsf@spindle.srvr.nix \
    --to=nick.alcock@esperi.org.uk \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bernd.schubert@fastmail.fm \
    --cc=dgilbert@interlog.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=nick.cheng@areca.com.tw \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).