From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: <linux-kernel@vger.kernel.org>, <mst@redhat.com>,
<sudeep.dutt@intel.com>, <arnd@arndb.de>,
<vincent.whitchurch@axis.com>, <stable@vger.kernel.org>
Subject: Re: [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev()
Date: Sun, 02 Aug 2020 21:26:49 -0700 [thread overview]
Message-ID: <87wo2gjqwm.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20200803042401.GA570882@kroah.com>
On Sun, 02 Aug 2020 21:24:01 -0700, Greg Kroah-Hartman wrote:
>
> On Sun, Aug 02, 2020 at 04:28:12PM -0700, Ashutosh Dixit wrote:
> > Fix the following sparse warnings in drivers/misc/mic/vop//vop_main.c:
> >
> > 551:58: warning: incorrect type in argument 1 (different address spaces)
> > 551:58: expected void const volatile [noderef] __iomem *addr
> > 551:58: got restricted __le64 *
> > 560:49: warning: incorrect type in argument 1 (different address spaces)
> > 560:49: expected struct mic_device_ctrl *dc
> > 560:49: got struct mic_device_ctrl [noderef] __iomem *dc
> > 579:49: warning: incorrect type in argument 1 (different address spaces)
> > 579:49: expected struct mic_device_ctrl *dc
> > 579:49: got struct mic_device_ctrl [noderef] __iomem *dc
> >
> > Cc: Michael S. Tsirkin <mst@redhat.com>
> > Cc: Sudeep Dutt <sudeep.dutt@intel.com>
> > Cc: Arnd Bergmann <arnd@arndb.de>
> > Cc: Vincent Whitchurch <vincent.whitchurch@axis.com>
> > Cc: stable <stable@vger.kernel.org>
>
> Why is this a stable thing? It doesn't fix a real bug, and sparse
> warnings are not needed for stable trees, unless this is the last sparse
> warning there.
It is the last sparse warning. Sorry I wasn't sure about stable so I
thought might as well. Please ignore if it's not required. Thanks.
next prev parent reply other threads:[~2020-08-03 4:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 23:28 [PATCH] vop: Add missing __iomem annotation in vop_dc_to_vdev() Ashutosh Dixit
2020-08-03 4:24 ` Greg Kroah-Hartman
2020-08-03 4:26 ` Dixit, Ashutosh [this message]
2020-08-03 11:12 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo2gjqwm.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=stable@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
--cc=vincent.whitchurch@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).