From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk,
sebastian.hesselbarth@gmail.com, andrew@lunn.ch,
jason@lakedaemon.net, fvdw@fvdw.eu, stable@vger.kernel.org
Subject: Re: [PATCH 3.10-3.17] ARM: orion: Fix DSA platform device after mvmdio conversion
Date: Tue, 06 Oct 2015 16:31:01 +0200 [thread overview]
Message-ID: <87wpv09ihm.fsf@free-electrons.com> (raw)
In-Reply-To: <1443902628-7861-2-git-send-email-f.fainelli@gmail.com> (Florian Fainelli's message of "Sat, 3 Oct 2015 13:03:48 -0700")
Hi Florian,
On sam., oct. 03 2015, Florian Fainelli <f.fainelli@gmail.com> wrote:
> DSA expects the host_dev pointer to be the device structure associated
> with the MDIO bus controller driver. First commit breaking that was
> c3a07134e6aa ("mv643xx_eth: convert to use the Marvell Orion MDIO
> driver"), and then, it got completely under the radar for a while.
>
> Reported-by: Frans van de Wiel" <fvdw@fvdw.eu>
> Fixes: c3a07134e6aa ("mv643xx_eth: convert to use the Marvell Orion MDIO driver")
> CC: stable@vger.kernel.org
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> This patch is for -stable kernels 3.10 to 3.17 (included)
is it something expected by the stable team?
I though that the normal flow was to send a fix, applying it on the
current kernel and from this point the stable team try to apply it on
all the relevant kernel. And only when the patch failed to apply you
have to send them a port of the patch for the given version.
Here you anticipate it, I find it intersting, but I wonder if it fits in
the stable team workflow.
Thanks,
Gregory
>
> arch/arm/plat-orion/common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/plat-orion/common.c b/arch/arm/plat-orion/common.c
> index 3ec6e8e8d368..3f02575e4cc8 100644
> --- a/arch/arm/plat-orion/common.c
> +++ b/arch/arm/plat-orion/common.c
> @@ -499,7 +499,7 @@ void __init orion_ge00_switch_init(struct dsa_platform_data *d, int irq)
>
> d->netdev = &orion_ge00.dev;
> for (i = 0; i < d->nr_chips; i++)
> - d->chip[i].mii_bus = &orion_ge00_shared.dev;
> + d->chip[i].mii_bus = &orion_ge_mvmdio.dev;
> orion_switch_device.dev.platform_data = d;
>
> platform_device_register(&orion_switch_device);
> --
> 2.1.0
>
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2015-10-06 14:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 20:03 [PATCH 3.18+] ARM: orion: Fix DSA platform device after mvmdio conversion Florian Fainelli
2015-10-03 20:03 ` [PATCH 3.10-3.17] " Florian Fainelli
2015-10-06 14:31 ` Gregory CLEMENT [this message]
2015-10-06 18:42 ` Florian Fainelli
2015-10-06 14:26 ` [PATCH 3.18+] " Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wpv09ihm.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=fvdw@fvdw.eu \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=sebastian.hesselbarth@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).