From: Thomas Gleixner <tglx@linutronix.de>
To: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Bjorn Helgaas <helgaas@kernel.org>
Cc: Jakub Kicinski <kuba@kernel.org>,
x86@kernel.org, jose.souza@intel.com, hpa@zytor.com,
bp@alien8.de, mingo@redhat.com, kai.heng.feng@canonical.com,
bhelgaas@google.com, linux-pci@vger.kernel.org, rudolph@fb.com,
xapienz@fb.com, bmilton@fb.com, stable@vger.kernel.org,
Arjan van de Ven <arjan@linux.intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"rafael@kernel.org" <rafael@kernel.org>
Subject: Re: [PATCH] x86/intel: Disable HPET on another Intel Coffee Lake platform
Date: Tue, 21 Sep 2021 22:18:00 +0200 [thread overview]
Message-ID: <87y27p65tz.ffs@tglx> (raw)
In-Reply-To: <82c1b753-586d-dadf-54de-6509e70a00ea@intel.com>
On Tue, Sep 21 2021 at 20:05, Rafael J. Wysocki wrote:
> On 9/19/2021 2:14 AM, Thomas Gleixner wrote:
>> What's the proper way to figure out whether PC10 is supported?
>
> I can't say without research. I think it'd be sufficient to check if
> C10 is supported, because asking for it is the only way to get PC10.
Do we have a common function for that or do I need to implement the
gazillionst CPUID query for that?
> However, even if it is supported, the problem is not there until the
> kernel asks for C10. So instead, I'd disable the TSC watchdog on the
> first attempt to ask the processor for C10 from the cpuidle code and I'd
> do that from the relevant drivers (intel_idle and ACPI idle).
>
> There would be no TSC watchdog for the C10 users, but wouldn't that be a
> fair game?
Not really because that makes any other HPET usage broken as well and we
can't pull the rug under that. So we are better off to disable it
upfront.
Thanks,
tglx
next prev parent reply other threads:[~2021-09-21 20:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-16 13:17 [PATCH] x86/intel: Disable HPET on another Intel Coffee Lake platform Jakub Kicinski
2021-09-16 15:07 ` Bjorn Helgaas
2021-09-16 15:30 ` Jakub Kicinski
2021-09-16 16:35 ` Paul E. McKenney
2021-09-17 2:57 ` Jakub Kicinski
2021-09-17 3:33 ` Paul E. McKenney
2021-09-17 9:11 ` Peter Zijlstra
2021-09-17 9:34 ` Peter Zijlstra
2021-09-19 0:14 ` Thomas Gleixner
2021-09-21 18:05 ` Rafael J. Wysocki
2021-09-21 20:18 ` Thomas Gleixner [this message]
2021-09-22 20:27 ` Rafael J. Wysocki
2021-09-22 22:21 ` Thomas Gleixner
2021-09-23 10:46 ` Rafael J. Wysocki
2021-09-17 14:00 ` Krzysztof Wilczyński
2021-09-17 14:58 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y27p65tz.ffs@tglx \
--to=tglx@linutronix.de \
--cc=arjan@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=bmilton@fb.com \
--cc=bp@alien8.de \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=jose.souza@intel.com \
--cc=kai.heng.feng@canonical.com \
--cc=kuba@kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael.j.wysocki@intel.com \
--cc=rafael@kernel.org \
--cc=rudolph@fb.com \
--cc=stable@vger.kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xapienz@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox