From: John Ogness <john.ogness@linutronix.de>
To: kernel test robot <lkp@intel.com>, Petr Mladek <pmladek@suse.com>
Cc: kbuild-all@lists.01.org,
Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, Petr Mladek <pmladek@suse.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] printk/console: Check consistent sequence number when handling race in console_unlock()
Date: Tue, 29 Jun 2021 22:59:57 +0206 [thread overview]
Message-ID: <87zgv8bdei.fsf@jogness.linutronix.de> (raw)
In-Reply-To: <202106300338.57cbEezZ-lkp@intel.com>
On 2021-06-30, kernel test robot <lkp@intel.com> wrote:
>>> kernel/printk/printk.c:2548:6: warning: variable 'next_seq' set but not used [-Wunused-but-set-variable]
I suppose the correct fix for this warning would be to change the NOP
macros. Currently they are:
#define prb_read_valid(rb, seq, r) false
#define prb_first_valid_seq(rb) 0
They should probably be something like (untested):
#define prb_read_valid(rb, seq, r) \
({ \
(void)(rb); \
(void)(seq); \
(void)(r); \
false; \
})
#define prb_first_valid_seq(rb) \
({ \
(void)(rb); \
0; \
})
John Ogness
next prev parent reply other threads:[~2021-06-29 20:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 14:33 [PATCH] printk/console: Check consistent sequence number when handling race in console_unlock() Petr Mladek
2021-06-29 14:48 ` John Ogness
2021-06-29 15:42 ` Sergey Senozhatsky
2021-06-30 7:58 ` Petr Mladek
2021-07-05 3:53 ` Sergey Senozhatsky
2021-06-29 19:44 ` kernel test robot
2021-06-29 20:53 ` John Ogness [this message]
2021-06-30 8:57 ` Petr Mladek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgv8bdei.fsf@jogness.linutronix.de \
--to=john.ogness@linutronix.de \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=stable@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox