Re: [Intel-gfx] [PATCH v4] drm/i915/ilk: Don't disable SSC source if it's in use

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 06 Jun 2016, Lyude Paul <cpaul@redhat.com> wrote:
> On Mon, 2016-06-06 at 14:30 +0300, Ville Syrjälä wrote:
>> On Thu, May 26, 2016 at 09:54:56AM +0200, Daniel Vetter wrote:
>> > 
>> > Queued for -next, thanks for the patch.
>> Looks like this one broke one of the ILKs in CI.
>> 
>> [   13.100979] [drm:ironlake_init_pch_refclk] has_panel 1 has_lvds 1 has_ck505
>> 0 using_ssc_source 1
>> [   13.101413] ------------[ cut here ]------------
>> [   13.101429] kernel BUG at drivers/gpu/drm/i915/intel_display.c:8528!
>> 
>> which is the 'BUG_ON(val != final)' at the end of ironlake_init_pch_refclk().
>> 
> Managed to find a machine at the office here that I could reproduce this on and
> figured out the problem with the patch. Unfortunately, the Optiplex 990 that I
> was seeing this issue on already left the office and the person in charge of it
> just went on PTO until the end of the week. For the time being don't merge this
> patch until I can get access to that machine again and make sure the fixed
> version of this patch still works on the 990. I'll send the new version once I'm
> able to test it.

Daniel already merged it, should we revert?

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center