Re: [PATCH v3] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

Re: [PATCH v3] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 776 bytes --]

Robert Dobrowolski <robert.dobrowolski@linux.intel.com> writes:
> [ text/plain ]
> From: Rafal Redzimski <rafal.f.redzimski@intel.com>
>
> Broxton B0 also requires XHCI_PME_STUCK_QUIRK.
> Adding PCI device ID for Broxton B and adding to quirk.
>
> Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
> Signed-off-by: Robert Dobrowolski <robert.dobrowolski@linux.intel.com>

you still missed mathias (who I've added to the Cc list). You can always
rely on scripts/get_maintainer.pl to give you sensible list of addresses
who should be Cced for a give patch.

And you're also missing a:

Cc: <stable@vger.kernel.org>

here on your commit log. Before Rafal's S-o-B.

See commit e18b7975c885bc3a938b9a76daf32957ea0235fa for example :-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]

[PATCH v3] usb: xhci: applying XHCI_PME_STUCK_QUIRK to Intel BXT B0 host

[Robert Dobrowolski]

From: Rafal Redzimski <rafal.f.redzimski@intel.com>

Broxton B0 also requires XHCI_PME_STUCK_QUIRK.
Adding PCI device ID for Broxton B and adding to quirk.

Signed-off-by: Rafal Redzimski <rafal.f.redzimski@intel.com>
Signed-off-by: Robert Dobrowolski <robert.dobrowolski@linux.intel.com>
---
Changes in v3:
 - Corrected cc list
Changes in v2:
 - Fixed commit message

 drivers/usb/host/xhci-pci.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index f0640b7..071b34a 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -48,6 +48,7 @@
 #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_XHCI		0xa12f
 #define PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI	0x9d2f
 #define PCI_DEVICE_ID_INTEL_BROXTON_M_XHCI		0x0aa8
+#define PCI_DEVICE_ID_INTEL_BROXTON_B_XHCI		0x1aa8

 static const char hcd_name[] = "xhci_hcd";

@@ -155,7 +156,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
 		(pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_LP_XHCI ||
 		 pdev->device == PCI_DEVICE_ID_INTEL_SUNRISEPOINT_H_XHCI ||
 		 pdev->device == PCI_DEVICE_ID_INTEL_CHERRYVIEW_XHCI ||
-		 pdev->device == PCI_DEVICE_ID_INTEL_BROXTON_M_XHCI)) {
+		 pdev->device == PCI_DEVICE_ID_INTEL_BROXTON_M_XHCI ||
+		 pdev->device == PCI_DEVICE_ID_INTEL_BROXTON_B_XHCI)) {
 		xhci->quirks |= XHCI_PME_STUCK_QUIRK;
 	}
 	if (pdev->vendor == PCI_VENDOR_ID_INTEL &&
-- 
1.9.1