From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Sun, 19 May 2013 21:58:20 +0900 Message-ID: <87zjvr5doz.wl%satoru.takeuchi@gmail.com> From: Satoru Takeuchi To: Greg Kroah-Hartman Cc: Al Viro , linux-kernel@vger.kernel.org, stable@vger.kernel.org, Alexander van Heukelum Subject: Re: [ 027/102] x86, vm86: fix VM86 syscalls: use SYSCALL_DEFINEx(...) In-Reply-To: <20130517235133.GC20969@kroah.com> References: <20130517213244.277411019@linuxfoundation.org> <20130517213247.228264908@linuxfoundation.org> <20130517224930.GW25399@ZenIV.linux.org.uk> <20130517235133.GC20969@kroah.com> MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: At Fri, 17 May 2013 16:51:33 -0700, Greg Kroah-Hartman wrote: > > On Fri, May 17, 2013 at 11:49:30PM +0100, Al Viro wrote: > > On Fri, May 17, 2013 at 02:35:42PM -0700, Greg Kroah-Hartman wrote: > > > 3.9-stable review patch. If anyone has any objections, please let me know. > > > > This is seriously wrong. For 3.9 you _need_ asmlinkage_protect() in that > > thing; by the time when that went into the tree, mainline already had > > it generated automatically by SYSCALL_DEFINE, so there was no point in > > that part of patch - the switch to SYSCALL_DEFINE alone did the job. > > For 3.9 it's very much needed; as the matter of fact, in 3.9 that commit > > is a no-op in the form you took. > > > > We can grab all prereqs into 3.9-stable (there's not that much of those), > > but that would be much more intrusive than the variant adding explicit > > asmlinkage_protect() in those two syscalls. > > Ok, Alexander was saying something was off here. > > Can someone send me just the needed patch to get this working properly, > and I will be glad to drop this one from the 3.9.x tree. I'll be able to do it tomorrow if there'll be not available then. Satoru