From: Jiri Slaby <jirislaby@kernel.org>
To: Jens Axboe <axboe@kernel.dk>, Denis Efremov <efremov@linux.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Guangshuo Li <lgs201920130244@gmail.com>
Cc: stable@vger.kernel.org
Subject: Re: [PATCH v2] floppy: fix reference leak on platform_device_register() failure
Date: Thu, 23 Apr 2026 07:11:06 +0200 [thread overview]
Message-ID: <897f442d-4e04-4b70-b716-38fd10b8af36@kernel.org> (raw)
In-Reply-To: <177645836617.906013.5675762942401997007.b4-ty@b4>
On 17. 04. 26, 22:39, Jens Axboe wrote:
>
> On Wed, 15 Apr 2026 22:57:08 +0800, Guangshuo Li wrote:
>> When platform_device_register() fails in do_floppy_init(), the embedded
>> struct device in floppy_device[drive] has already been initialized by
>> device_initialize(), but the failure path jumps to out_remove_drives
>> without dropping the device reference for the current drive.
>>
>> Previously registered floppy devices are cleaned up in out_remove_drives,
>> but the device for the drive that fails registration is not, leading to
>> a reference leak.
>>
>> [...]
>
> Applied, thanks!
>
> [1/1] floppy: fix reference leak on platform_device_register() failure
> commit: e784f2ea0b4fd0e7b70028ff8218f22456c5dcf8
The patch is likely wrong. Given the pdev is static, the struct device
has no ->release, so releasing it will trigger a warning. AFAIR, the
consensus was to fix platform_device_register() proper.
thanks,
--
js
suse labs
prev parent reply other threads:[~2026-04-23 5:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-15 14:57 [PATCH v2] floppy: fix reference leak on platform_device_register() failure Guangshuo Li
2026-04-17 20:39 ` Jens Axboe
2026-04-23 5:11 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=897f442d-4e04-4b70-b716-38fd10b8af36@kernel.org \
--to=jirislaby@kernel.org \
--cc=axboe@kernel.dk \
--cc=efremov@linux.com \
--cc=gregkh@suse.de \
--cc=lgs201920130244@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox